First, there was a small mistake in the _beforeclose event:
Private Sub Workbook_BeforeClose(Cancel As Boolean)
On Error Resume Next
Application.CommandBars("Assumptions and Other Options").Delete
End Sub
But you should have been yelled at when the workbook closed. If you weren't,
then maybe you didn't put the code in the correct spot. Make sure it's behind
the ThisWorkbook module.
All that other stuff would be in a general module.
After that change, it worked for me. (the toolbar appeared when I opened the
workbook and was deleted when I closed the workbook.)
Now the easy thing to check--are you sure you attached it correctly? Are you
sure you used the correct name (in code, too).
If you do View|toolbars, do you see your toolbar--maybe it's just not
visible????
if it's not visible, maybe adding this code behind the ThisWorkbook module will
help:
Private Sub Workbook_Open()
On Error Resume Next
Application.CommandBars("assumptions and other options").Visible = True
If Err.Number <> 0 Then
MsgBox "error showing toolbar"
Err.Clear
End If
On Error GoTo 0
End Sub
=======
You may want to take one more look at creating the toolbar on the fly. It's
really pretty simple and a lot less prone to errors (well, I think).