Using Trim in a Userform

C

Curtd

I have a Userform that I fill out and have the information entered in a cell
on a worksheet, I am trying to use Trim when entering it in the cell to
remove any duplicate spaces. Can someone help me out and let me know why
this isn't working and what I need to change to get it to work. Thank you
for your help.

ws.Cells(iRow, 2) = Trim(txtProblem.Value)
 
R

Rick Rothstein

The worksheet's TRIM function does not work the same as the built-in VB Trim
function (which only removes spaces from the ends of the text). You can tap
into the worksheet's TRIM function, to do what you want though, like this...

ws.Cells(iRow, 2) = WorksheetFunction.Trim(txtProblem.Value)
 
R

Rich Locus

Hello:

Here's a little space stripper function you can call.

Function StripExtraSpaces(ByVal InputString As String) As String
Dim i, j As Long
Dim boolLastItemWasSpace As Boolean
j = 0
boolLastItemWasSpace = False

InputString = Trim(InputString)
For i = 1 To Len(InputString)
If Mid(InputString, i, 1&) = " " Then
If Not boolLastItemWasSpace Then
j = j + 1&
Mid(InputString, j, 1&) = Mid(InputString, i, 1&)
boolLastItemWasSpace = True
Else
boolLastItemWasSpace = False
End If
Else
j = j + 1&
Mid(InputString, j, 1&) = Mid(InputString, i, 1&)
End If
Next i
StripExtraSpaces = Left(InputString, j) ' String Is Now Shorter
End Function
 
R

Rich Locus

Hello:
If this function solves your problem,
please check the "Answers My Question" button.

This function trims leading and trailing spaces,
and then allows only one single space between
contiguous words in a string:

Function StripExtraSpaces(ByVal InputString As String) As String
Dim i, j As Long
Dim boolLastItemWasSpace As Boolean
j = 0
boolLastItemWasSpace = False

InputString = Trim(InputString)
For i = 1 To Len(InputString)
If Mid(InputString, i, 1&) = " " Then
If Not boolLastItemWasSpace Then
j = j + 1&
Mid(InputString, j, 1&) = Mid(InputString, i, 1&)
boolLastItemWasSpace = True
Else
boolLastItemWasSpace = False
End If
Else
j = j + 1&
Mid(InputString, j, 1&) = Mid(InputString, i, 1&)
End If
Next i
StripExtraSpaces = Left(InputString, j) ' String Is Now Shorter
End Function
 
R

Rich Locus

Hello:
If this function solves your problem,
please check the "Answers My Question" button.

This function trims leading and trailing spaces,
and then allows only one single space between
contiguous words in a string:

Function StripExtraSpaces(ByVal InputString As String) As String
Dim i, j As Long
Dim boolLastItemWasSpace As Boolean
j = 0
boolLastItemWasSpace = False

InputString = Trim(InputString)
For i = 1 To Len(InputString)
If Mid(InputString, i, 1&) = " " Then
If Not boolLastItemWasSpace Then
j = j + 1&
Mid(InputString, j, 1&) = Mid(InputString, i, 1&)
boolLastItemWasSpace = True
Else
boolLastItemWasSpace = False
End If
Else
j = j + 1&
Mid(InputString, j, 1&) = Mid(InputString, i, 1&)
End If
Next i
StripExtraSpaces = Left(InputString, j) ' String Is Now Shorter
End Function
 
R

Rich Locus

Hello:
If this function solves your problem,
please check the "Answers My Question" button.

This function trims leading and trailing spaces,
and then allows only one single space between
contiguous words in a string:

Function StripExtraSpaces(ByVal InputString As String) As String
Dim i, j As Long
Dim boolLastItemWasSpace As Boolean
j = 0
boolLastItemWasSpace = False

InputString = Trim(InputString)
For i = 1 To Len(InputString)
If Mid(InputString, i, 1&) = " " Then
If Not boolLastItemWasSpace Then
j = j + 1&
Mid(InputString, j, 1&) = Mid(InputString, i, 1&)
boolLastItemWasSpace = True
Else
boolLastItemWasSpace = False
End If
Else
j = j + 1&
Mid(InputString, j, 1&) = Mid(InputString, i, 1&)
End If
Next i
StripExtraSpaces = Left(InputString, j) ' String Is Now Shorter
End Function
 
R

Rick Rothstein

When I run your code, I get two spaces left between words, not one.

I'm guessing you didn't see my first posting in this thread, did you? Here
is what I posted modified to fit your function header...

Function StripExtraSpaces(ByVal InputString As String) As String
StripExtraSpaces = WorksheetFunction.Trim(InputString)
End Function

This code, which is much shorter than yours, outputs what I think you
intended your function to output.
 
R

Rich Locus

Rick:
You are correct. I like your approach better. I am, however, still going
to fix the two space bug in the function.
Regards,
 
R

Rich Locus

Rick:
Here is the corrected code which can be used to strip any character... not
just spaces, by changing the literal. However, for spaces, you definitely
have the correct solutions.

Regards to the MVP.

Function StripExtraSpaces(ByVal InputString As String) As String
Dim i, j As Long
Dim boolLastItemWasSpace As Boolean
j = 0
boolLastItemWasSpace = False

InputString = Trim(InputString)
For i = 1 To Len(InputString)
If Mid(InputString, i, 1&) = " " Then
If Not boolLastItemWasSpace Then
j = j + 1&
Mid(InputString, j, 1&) = Mid(InputString, i, 1&)
boolLastItemWasSpace = True
End If
Else
j = j + 1&
Mid(InputString, j, 1&) = Mid(InputString, i, 1&)
boolLastItemWasSpace = False
End If
Next i
StripExtraSpaces = Left(InputString, j) ' String Is Now Shorter
End Function
 
R

Rick Rothstein

Well, if you want to do this without calling the WorksheetFunction property
(of the Application object), then I would use this (still) much shorter
macro...

Function StripExtraSpaces(ByVal InputString As String) As String
StripExtraSpaces = Trim(InputString)
Do While InStr(StripExtraSpaces, " ")
StripExtraSpaces = Replace(StripExtraSpaces, " ", " ")
Loop
End Function
 
R

Rick Rothstein

I'm not sure how much sense it makes to remove non-space characters from the
beginning and end of a text string and then collapse multiple internal
non-space characters down to a single occurrence of that non-space
character, but if that is what you want, then I would probably do it this
way (where you can pass in the non-space character in the optional 2nd
argument, which defaults to the space character if omitted)...

Function StripExtraSpaces(ByVal InputString As String, _
Optional ReplaceChar As String = " ") As String
If ReplaceChar <> " " Then
InputString = Replace(InputString, " ", Chr(1))
InputString = Replace(InputString, ReplaceChar, " ")
End If
InputString = Trim(InputString)
Do While InStr(InputString, " ")
InputString = Replace(InputString, " ", " ")
Loop
If ReplaceChar <> " " Then
InputString = Replace(InputString, " ", ReplaceChar)
InputString = Replace(InputString, Chr(1), " ")
End If
StripExtraSpaces = InputString
End Function
 
C

Chip Pearson

Here's a function from my standard library that I use to trim and
single space a string. It is pure VBA, with no reliance on Excel, so
can be used in any VBA application.

Function SingleSpace(S As String) As String
Dim T As String
Dim N As Long
T = Trim(S)
N = InStr(1, T, Space(2), vbBinaryCompare)
Do Until N = 0
T = Replace(T, Space(2), Space(1))
N = InStr(1, T, Space(2), vbBinaryCompare)
Loop
SingleSpace = T
End Function

Cordially,
Chip Pearson
Microsoft Most Valuable Professional,
Excel, 1998 - 2010
Pearson Software Consulting, LLC
www.cpearson.com
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Similar Threads

Create a yes no message on a command button on click 0
Compile Error: Method or data member not found error 0
Entry Form Problem 3
Help with my userform code 0
listbox -shows table of information - option to select and edit ro 2
Userform VBA Complie Error: Method or data memeber not found 3
userform duplicate control not working in my code. Thank you 13
Run-time Error '1004' 1

Top