string or Stringbuilder??

[ALI-R]

Shall I use stringbuilder in the following statement? why?

string devInfo =
"<DeviceInfo>" +
"<Toolbar>False</Toolbar>" +
"<MarginLeft>0in</MarginLeft>" +
"<MarginRight>0in</MarginRight>" +
"<MarginTop>0in</MarginTop>" +
"<MarginBottom>0in</MarginBottom>" +
"<PageHeight>" +
myVariable1.toString() +
"</PageHeight>" +
"<PageWidth>" +
myVariable2.toString();

thanks for your help.
Ali

 

[Peter Rilling]

Is this inside of a loop?

If this is executed once, a StringBuilder might not be necessary as the
performance gain might not be substantial. Although there are times when
StringBuilder are beneficial, they may not always be necessary.

 

[Bret Pehrson]

Shall I use stringbuilder in the following statement? why?

string devInfo =
"<DeviceInfo>" +
"<Toolbar>False</Toolbar>" +
"<MarginLeft>0in</MarginLeft>" +
"<MarginRight>0in</MarginRight>" +
"<MarginTop>0in</MarginTop>" +
"<MarginBottom>0in</MarginBottom>" +
"<PageHeight>" +
myVariable1.toString() +
"</PageHeight>" +
"<PageWidth>" +
myVariable2.toString();

thanks for your help.
Ali

String should be just fine. StringBuilder is good when you are adding to the
string and/or otherwise causing it to resize numerous times (e.g. in a loop).

 

[Jon Skeet [C# MVP]]

Shall I use stringbuilder in the following statement? why?

string devInfo =
"<DeviceInfo>" +
"<Toolbar>False</Toolbar>" +
"<MarginLeft>0in</MarginLeft>" +
"<MarginRight>0in</MarginRight>" +
"<MarginTop>0in</MarginTop>" +
"<MarginBottom>0in</MarginBottom>" +
"<PageHeight>" +
myVariable1.toString() +
"</PageHeight>" +
"<PageWidth>" +
myVariable2.toString();

No - that ends up becoming one single String.Concat call with four
parameters - a single constant string "<DeviceInfo><Toolbar>[...]",
myVariable1.ToString(), "</PageHeight><PageWidth>" and
myVariable2.ToString().

 

[ALI-R]

No,it is not in the loop.

Is this inside of a loop?

If this is executed once, a StringBuilder might not be necessary as the
performance gain might not be substantial. Although there are times when
StringBuilder are beneficial, they may not always be necessary.