Strange pimpl problem - const correctness not respected


D

Daniel Lidström

Hello!

I have a strange problem with my pimpl implementation. What happens is that
const correctness is not respected. Let me go straight to the code:

#include <iostream>

struct Geometry {};

class LineData
{
class LineDataImpl;
LineDataImpl& mImpl;

public:

LineData();

const Geometry& GetGeometry() const;
/* */ Geometry& GetGeometry() /* */;
};

class LineData::LineDataImpl
{
Geometry mGeometry;

public:

const Geometry& GetGeometry() const
{
std::cout << "Calling const overload" << std::endl;
return mGeometry;
}

Geometry& GetGeometry()
{
std::cout << "Calling non-const overload" << std::endl;
return mGeometry;
}
};

LineData::LineData()
: mImpl(*(new LineDataImpl))
{ }

const Geometry& LineData::GetGeometry() const
{
return mImpl.GetGeometry();
}

Geometry& LineData::GetGeometry()
{
return mImpl.GetGeometry();
}

int main()
{
const LineData lineData;
const Geometry& geometry = lineData.GetGeometry();

return 0;
}

This sample shows that despite my intentions of being const correct, the
compiler ends up calling the non-const overload. What is going on here?
I'm using Visual Studio 2008, SP1.

Thanks in advance!
 
Ad

Advertisements

T

Tamas Demjen

Daniel said:
Hello!

I have a strange problem with my pimpl implementation. What happens is
that const correctness is not respected. Let me go straight to the code:

[snip]

class LineData
{
class LineDataImpl;
LineDataImpl& mImpl;

That's because your mImpl is not const.
[snip]
const Geometry& LineData::GetGeometry() const
{
return mImpl.GetGeometry();

Change this to:
return static_cast<const LineDataImpl&>(mImpl).GetGeometry();

Tom
 
T

Tamas Demjen

Daniel said:
LineData::LineData()
: mImpl(*(new LineDataImpl))
{ }

Also note that this new leaks. I assume this is a test only, but your
real code should arrangements to delete this pointer.

Tom
 
Ad

Advertisements

D

Daniel Lidström

Tamas Demjen said:
Also note that this new leaks. I assume this is a test only, but your real
code should arrangements to delete this pointer.

Yes, the real code does delete the pointer :)
Thanks for the workaround Tamas!
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Top