Question regarding Shared Functions or Subs

P

Patriot

I wonder if it is threadsafe to have a Shared Function or Sub like
this:

Public Class Data1
Public Shared Function Query1(Byref sCnxn as String, Byval sSql As
String) As DataTable
Dim oCnxn As New SqlConnection(sCnxn)
Dim oCmd As New SqlCommand(sSql, oCnxn)
Dim oDs As New DataSet

' Mark the Command as a SPROC
oCmd.CommandType = CommandType.Text

oCnxn.Open()
Dim oDa As SqlDataAdapter = New SqlDataAdapter(oCmd)
oDa.Fill(oDs, "result")

oCmd.Dispose()
oCnxn.Close()

Dim dt As DataTable = oDs.Tables("result").Copy
oDs.Clear()
oDs = Nothing
oDa = Nothing

Return dt
End Function
End Class

Will I have any problem with multiple concurrent web requests?

Thanks
 
M

Mattias Sjögren

Will I have any problem with multiple concurrent web requests?

I don't tnhink so, you're not using any shared state as far as I can
see.


Mattias
 
P

Patriot

Thank you for your feedback Mattias.

I was a bit worried that the connection will be closed unexpectedly. I
guess it'll be alright since none of the variables or parameters are
shared.

Thanks again.
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Top