That's not a clear-cut question. I think you need to understand the order of
events and work out what is best for your app.
If you set the form as you are doing outwith the form module, then you
automatically load the form if it is not loaded, that is the form is loaded
into memory but not shown.
When you load the form, the Userform_Initialize event is triggered, so you
could put that code in Initialize if it is required to refresh whenever a
for is loaded.
When you show the form the Userform_Activate event is triggered. So you can
add code here that you want every time the form is shown (which you control
via code remember).
The problem (?) with doing it outwith the form module is that it is
effectively Initialize event when you might want it to be Activate event.
Generally speaking, I try to avoid setting the form from a standard code
module, preferring to do it from within the form module itself. Of course,
there are always exceptions, such as hiding (not unloading) a form and
testing a form public property from the standard code module to determine
next action.
--
HTH
RP
(remove nothere from the email address if mailing direct)
.