Passing text to VBA code

[Ed Davis]

I have this line in several macros (7) to be exact.
Each one of these macros is called when another Macro is run (Changing
something on a sheet).
The macros are exactly the same except this line where this line says
"Before_I_Update"
Is there a way to pass "Before_I_Update" from the macro that is calling it?
That way I can have only 1 macro that runs this code and pass the "string"
to it.
BTW I have three workbooks with the same amount of macros with this code.

ThisWorkbook.Path & "\Backup\Loja\Work\Before_I_Update (" & strSH & ")" &
Format(Now, " dd-mm-yy hh-mm-ss") & ".xls"

 

[Bob Phillips]

Sub TopLevelMacro()
Dim var As String

var = "Before_I_Update"

Call Macro1(var)

Call macro2(var)

'etc
End Sub

Sub Macro1(inVal As String)
ThisWorkbook.Path & "\Backup\Loja\Work\" & inVal & (" & strSH & ")" &
Format(Now, " dd-mm-yy hh-mm-ss") & ".xls"
end sub

and so on

 

[Stefi]

Try this way:

Sub callermacro()

Call calledmacro("Before_I_Update")

End Sub

Sub calledmacro(text_param As String)

param_filename = ThisWorkbook.Path & "\Backup\Loja\Work\" & text_param & "("
& strSH & ")" & _
Format(Now, " dd-mm-yy hh-mm-ss") & ".xls"

End Sub

Regards,
Stefi

„Ed Davis†ezt írta:

 

[Ed Davis]

I now have this code and I am getting a compile error on " & Format(Now,"
EXPECTED END OF STATEMENT.

ThisWorkbook.Path & "\Backup\Sales\Work\" &inVal& (" & strSH & ")" &
Format(Now," dd-mm-yy hh-mm-ss") & ".xls"

--
Thank You in Advance
Ed Davis

Sub TopLevelMacro()
Dim var As String

var = "Before_I_Update"

Call Macro1(var)

Call macro2(var)

'etc
End Sub

Sub Macro1(inVal As String)
ThisWorkbook.Path & "\Backup\Loja\Work\" & inVal & (" & strSH & ")" &
Format(Now, " dd-mm-yy hh-mm-ss") & ".xls"
end sub

and so on

 

[Stefi]

Bob missed a " after inVal&:
ThisWorkbook.Path & "\Backup\Sales\Work\" &inVal& "(" & strSH & ")" &
Format(Now," dd-mm-yy hh-mm-ss") & ".xls"

Instead of
ThisWorkbook.Path & "\Backup\Sales\Work\" &inVal& (" & strSH & ")" &
Format(Now," dd-mm-yy hh-mm-ss") & ".xls"
Stefi


„Ed Davis†ezt írta:

I now have this code and I am getting a compile error on " & Format(Now,"
EXPECTED END OF STATEMENT.

ThisWorkbook.Path & "\Backup\Sales\Work\" &inVal& (" & strSH & ")" &
Format(Now," dd-mm-yy hh-mm-ss") & ".xls"

 

[Ed Davis]

I am getting a compile error with this code also on " & Format(Now,"
EXPECTED END OF STATEMENT.

 

[Ed Davis]

This is now the whole line of code and I am getting a syntax error on the
line.

ActiveWorkbook.SaveAs ThisWorkbook.Path & "\Backup\Sales\Work\"&inval&"(" &
strSH & ")" & Format(Now, " dd-mm-yy hh-mm-ss") & ".xls",
FileFormat:=xlNormal, Password:="", WriteResPassword:="",
ReadOnlyRecommended:=False, CreateBackup:=False

 

[Stefi]

Coming back to the right threead:

a space has been inserted
manually before and after InVal. VB editor sometimes doesn't recognize & as
an operator that must be separated by a space from the operands:


ActiveWorkbook.SaveAs ThisWorkbook.Path & "\Backup\Sales\Work\" & inval &
"(" & _
strSH & ")" & Format(Now, " dd-mm-yy hh-mm-ss") & ".xls", _
FileFormat:=xlNormal, Password:="", WriteResPassword:="", _
ReadOnlyRecommended:=False, CreateBackup:=False

Stefi


„Ed Davis†ezt írta:

 

[Ed Davis]

I checked and no spaces are there, but I retyped it anyway and get a
expected end of statement on "(".

 

[Stefi]

Try to copy/Paste this format, it has no errors on my machine:

ActiveWorkbook.SaveAs ThisWorkbook.Path & _
"\Backup\Sales\Work\" & inval & "(" & _
strSH & ")" & Format(Now, " dd-mm-yy hh-mm-ss") & ".xls", _
FileFormat:=xlNormal, Password:="", WriteResPassword:="", _
ReadOnlyRecommended:=False, CreateBackup:=False

Stefi


„Ed Davis†ezt írta:

 

[Ed Davis]

Thank you that did it.

 

[Stefi]

You are welcome! Thanks for the feedback!
Stefi
Clicking the YES button will be appreciated.


„Ed Davis†ezt írta:

 

[Bob Phillips]

I thought you were a NG girl Stefi, not a forum type <g>

 

[Stefi]

Hi Bob,

Please, explain, what is a NG girl, I've never heard it! And what does forum
type mean? And finally, what <g> stands for?

Regards,
Stefi


„Bob Phillips†ezt írta:

 

[Bob Phillips]

NG - newsgroups - the UseNet groups that are accessed through a mail client
and don't need a web browser

forum type - one who uses the web based forums

<g> - grin

 

[Stefi]

Thanks!
Anyway, I'm a boy!
Stefi


„Bob Phillips†ezt írta:

 

[Bob Phillips]

Sorry about that, you are clearly not the Stefi I was thinking of, she is
definitely female.