Macro Open Files

[Guest]

Hello

I am writing a macro that prompts a user to enter two values. These values
are need to open certain files on the computer. The two values are two
folders the document is located under. I am getting the error "divide by zero"

Here's my code:

Sub Macro2()

Dim filetypenm
filetypenm = InputBox("Enter File Name you would like to compare")

Dim nm
nm = InputBox("Enter Year you would like to compare")
Application.GetOpenFilename ("""C:\Documents and Settings\All
Users\Documents\Coop Students\Small Package Rates\UPS rates\" & nm \ Air \ "
& filetypenm ")

Im sure it's just a coding problem that I can't see. Any help would be
greatly appreciated. Have been stuck for 2 days! Am making progress though
thanks to replies!

MSHO

 

[Guest]

Try this... I think it is a problem with your quotation marks...

Sub Macro2()

Dim filetypenm As String
filetypenm = InputBox("Enter File Name you would like to compare")

Dim nm As Integer
nm = InputBox("Enter Year you would like to compare")
Application.GetOpenFilename ("C:\Documents and
Settings\AllUsers\Documents\Coop Students\Small Package Rates\UPS rates\" &
nm & "\Air\" & filetypenm)

End Sub

Also make sure you declare your variables with a type otherwise they are
variants which are very innefficient. Check out this link on declaring
variables.

http://www.cpearson.com/excel/variables.htm

 

[Helmut Weber]

Dim filetypenm as string
filetypenm = InputBox("Enter File Name you would like to compare")

Dim nm as string
nm = InputBox("Enter Year you would like to compare")

dim sTmp as string
stmp = chr(34) & "C:\Documents and Settings\All Users\"
stmp = stmp & "Documents\Coop Students\"
stmp = stmp & "Small Package Rates\UPS rates\"
stmp = stmp & nm & "\ Air \"
stmp = stmp & filetypenm & chr(34)

Application.GetOpenFilename(stmp)

Helmut Weber