Improvement to sub: Detect data extent and convert to values

[Max]

Hi guys,

I'm trying to improve the sub below, so that:

a) it auto-detects the extent of the data range in col A
(A2:Ax, where x = last cell)
and inserts the vlookup formula correspondingly into col C

b) it will then auto-convert the returns in col C to values,
after calculation

Sub InsertFormulas()
With Sheets("Book In").Range("C2:C100")
' Adjust the range in col C to suit
' the max likely number of data rows in col A
.FormulaR1C1 = _
"=IF(RC1="""","""",VLOOKUP(RC1,PartNumbers!R2C1:R1000C2,2,FALSE))"
End With
End Sub

Thanks for insights

 

[Frank Kabel]

Hi
try

Sub InsertFormulas()
dim lastrow as long
With Sheets("Book In")
lastrow = .Cells(Rows.count, "A").End(xlUp).row
end with
with Sheets("Book In").Range("C2:C" & lastrow)
' Adjust the range in col C to suit
' the max likely number of data rows in col A
.FormulaR1C1 = _
"=IF(RC1="""","""",VLOOKUP(RC1,PartNumbers!
R2C1:R1000C2,2,FALSE))"

'convert formulas to values
..value=.value
End With
End Sub

 

[Max]

Works great!

Many thanks, Frank

 

[Patrick Molloy]

sorry to butt in ... but some tidy up....


Sub InsertFormulas()
dim lastrow as long
dim sFormula as string

sFormula="=IF(RC1="""","""",VLOOKUP(RC1, _
PartNumbers!R2C1:R1000C2,2,FALSE))"
With Sheets("Book In")
lastrow = .Cells(Rows.count, "A").End(xlUp).row
with .Range(.Range("C2"),.Cells(lastrow,"C"))

 

[Frank Kabel]

Hi Patrick
no problem at all

-----Original Message-----
sorry to butt in ... but some tidy up....


Sub InsertFormulas()
dim lastrow as long
dim sFormula as string

sFormula="=IF(RC1="""","""",VLOOKUP(RC1, _
PartNumbers!R2C1:R1000C2,2,FALSE))"
With Sheets("Book In")
lastrow = .Cells(Rows.count, "A").End(xlUp).row
with .Range(.Range("C2"),.Cells(lastrow,"C"))
.

 

[Max]

Hey, that works great, too!

Thanks for the "tidy up", Patrick

I'm going to try and grasp the refinements made ..