If-Then Help! Seems simple

  • Thread starter Thread starter Brandon Johnson
  • Start date Start date
B

Brandon Johnson

This question is hard to explain so i will show you an example:

dim strng as string

Set find = CurrentDb.OpenRecordset("Name", dbOpenDynaset)
find.MoveFirst

If chkJob.value = -1 Then
If Len(strng) = 0 Then
strng = "find!title = " & cboJobtitle
Else
strng = strng & " AND find!title = " & cboJobtitle
End If
End If

If chkyears.value = -1 Then
If Len(strng) = 0 Then
strng = "find!yrs = " & txtYrs
Else
strng = strng & " AND find!yrs = " & txtYrs
End If
End If
..
..
..
Do Until find.EOF
If strng Then
ReDim Preserve names(x)
names(x) = find!id
x = x + 1
End If
loop


Im getting a data type runtime error#13 at the bottom where it trys to
do the "if strng then" within the loop. Does anyone have any
suggestions. it would help me out alot.
 
Brandon Johnson said:
This question is hard to explain so i will show you an example:

dim strng as string

Set find = CurrentDb.OpenRecordset("Name", dbOpenDynaset)
find.MoveFirst

If chkJob.value = -1 Then
If Len(strng) = 0 Then
strng = "find!title = " & cboJobtitle
Else
strng = strng & " AND find!title = " & cboJobtitle
End If
End If

If chkyears.value = -1 Then
If Len(strng) = 0 Then
strng = "find!yrs = " & txtYrs
Else
strng = strng & " AND find!yrs = " & txtYrs
End If
End If
..
..
..
Do Until find.EOF
If strng Then
ReDim Preserve names(x)
names(x) = find!id
x = x + 1
End If
loop


Im getting a data type runtime error#13 at the bottom where it trys to
do the "if strng then" within the loop. Does anyone have any
suggestions. it would help me out alot.
Click to expand...

"If strng Then" is an evaluation of a boolean, but strng is a string
variable. You're code sees the value of strng as a string rather than as
runable code.

I think you should move the code where you're evaluating the checboxes
inside the Do Until loop and directly evaluate the field values rather than
trying to build a filter string.

Barry
 
Barry is right about the boolean, but as a side note if you start with strng
= "" after movefirst you can do away with the len(strng) and else code, and
just have;

If chkJob.value = -1 Then
strng = strng & " AND find!title = " & cboJobtitle
End If

TonyT
 
Back
Top