Combo box change event fires twice


S

Smurfette18

Hello,

I have combo box that allows users to select from a list or enter a
value freeform. I also have a change event for this combo box.
Everything works fine when the user selects from the list, but when he
or she enters a value by hand, the change event sometimes fires twice
for no apparent reason. For instance, if you select "0" from the
list, it fires once, but if you type "0" directly in the box, it fires
twice. I already tried disabling events before my code and re-
enabling them after it runs, but that did not work. Any help would be
appreciated.

Thanks!
 
Ad

Advertisements

R

Rick Rothstein \(MVP - VB\)

The Change event of a ComboBox gets fired only when the text is manually
changed... not from selecting from the list. I suspect you have code in your
Change event which you think is doing something that actually is happening
automatically; hence, when you type into the text field, whatever happens
automatically takes place and then something in your Change event code makes
it happen again. I can't tell you any more than that because you didn't post
your code for us to look at.

Rick
 
S

Smurfette18

Rick,

Thanks for your response. It doesn't seem to matter what code I have
in the change event. To troubleshoot the problem I commented out my
code down to this (the combo box is originally set to the default
value 10):

Private Sub ComboBox1_Change()

Dim TestVar as Variant
TestVar = 6

End Sub

I played around with this for a bit, and it seems the problem is
related to the MatchEntry property. If MatchEntry is set to "1 -
fmMatchEntryComplete", the event doesn't fire when I change the
default value to zero manually (it does fire as it should when I enter
any other number by hand or select a value from the list). After this
first peculiar no-fire, it works fine. When MatchEntry is set to "2 -
fmMatchEntryNone", the event fires only once if I select an item from
the list or enter a value manually after entering the prior value
manually. The first time I enter a value manually after selecting the
prior value from the list, the event fires twice for some strange
reason. I would like to keep MatchEntry set to "None", but I need to
get this event to stop firing when it shouldn't.
 
T

Tim Zych

The Change event of a ComboBox gets fired only when the text is manually
changed... not from selecting from the list.

I don't think so Rick. If you create a sample form/cbo and try it out you
should see. Type in a value, or select from the list in any way, and the
change event is triggered. The help file has been updated, I believe, to
include a lot more details about the control and the change/click events
than prior versions documented.

----------------------------------------------------------
From the help file in XL2003, Combobox control -> Events ->
------------------
Change event:
------------------
The Change event occurs when the setting of the Value property changes,
regardless of whether the change results from execution of code or a user
action in the interface.
Note In some cases, the Click event may also occur when the Value property
changes. However, using the Change event is the preferred technique for
detecting a new value for a property.
----------------------------------------------------------

Private Sub ComboBox1_Change()
MsgBox "change"
End Sub

Private Sub UserForm_Initialize()
With Me.ComboBox1
.AddItem "a"
.AddItem "b"
.AddItem "c"
End With
End Sub


Tim Zych
SF, CA
 
R

Rick Rothstein \(MVP - VB\)

You are absolutely right... what I said does not apply to the VBA ComboBox
in the Office product line. It *does* apply to the compiled VB world's
ComboBox and I made the mistake of assuming the same base control would be
behind both implementations. But, as your message points out, I was wrong in
that belief and I apologize if I have misled anyone because of it.

I do have to say, though, that having the Change event fire whether the text
is changed *or* the list is Clicked seems to make it a less useful event
than the one in the compiled VB world. Over there, a Click event is reserved
solely for a manual selection from the list itself and the Change event for
a manual change to the text in the text field itself... there is no overlap
between the two and that makes, in my opinion, for easier coding. I'm a
little surprised that this event model was not carried through to the Office
ComboBox.

By the way, thank you for bringing this to my attention... I really
appreciate it.

Rick
 
Joined
Jun 20, 2012
Messages
2
Reaction score
0
You are absolutely right... what I said does not apply to the VBA ComboBox
in the Office product line. It *does* apply to the compiled VB world's
ComboBox and I made the mistake of assuming the same base control would be
behind both implementations. But, as your message points out, I was wrong in
that belief and I apologize if I have misled anyone because of it.

I do have to say, though, that having the Change event fire whether the text
is changed *or* the list is Clicked seems to make it a less useful event
than the one in the compiled VB world. Over there, a Click event is reserved
solely for a manual selection from the list itself and the Change event for
a manual change to the text in the text field itself... there is no overlap
between the two and that makes, in my opinion, for easier coding. I'm a
little surprised that this event model was not carried through to the Office
ComboBox.

By the way, thank you for bringing this to my attention... I really
appreciate it.

Rick


"Tim Zych" <[email protected]@[email protected]> wrote in message
news:[email protected]
>> The Change event of a ComboBox gets fired only when the text is manually
>> changed... not from selecting from the list.

>
> I don't think so Rick. If you create a sample form/cbo and try it out you
> should see. Type in a value, or select from the list in any way, and the
> change event is triggered. The help file has been updated, I believe, to
> include a lot more details about the control and the change/click events
> than prior versions documented.
>
> ----------------------------------------------------------
> From the help file in XL2003, Combobox control -> Events ->
> ------------------
> Change event:
> ------------------
> The Change event occurs when the setting of the Value property changes,
> regardless of whether the change results from execution of code or a user
> action in the interface.
> Note In some cases, the Click event may also occur when the Value property
> changes. However, using the Change event is the preferred technique for
> detecting a new value for a property.
> ----------------------------------------------------------
>
> Private Sub ComboBox1_Change()
> MsgBox "change"
> End Sub
>
> Private Sub UserForm_Initialize()
> With Me.ComboBox1
> .AddItem "a"
> .AddItem "b"
> .AddItem "c"
> End With
> End Sub
>
>
> Tim Zych
> SF, CA
>
>
> "Rick Rothstein (MVP - VB)" <[email protected]> wrote in
> message news:[email protected]
>> The Change event of a ComboBox gets fired only when the text is manually
>> changed... not from selecting from the list. I suspect you have code in
>> your Change event which you think is doing something that actually is
>> happening automatically; hence, when you type into the text field,
>> whatever happens automatically takes place and then something in your
>> Change event code makes it happen again. I can't tell you any more than
>> that because you didn't post your code for us to look at.
>>
>> Rick
>>
>>
>> "Smurfette18" <[email protected]> wrote in message
>> news:[email protected]m...
>>> Hello,
>>>
>>> I have combo box that allows users to select from a list or enter a
>>> value freeform. I also have a change event for this combo box.
>>> Everything works fine when the user selects from the list, but when he
>>> or she enters a value by hand, the change event sometimes fires twice
>>> for no apparent reason. For instance, if you select "0" from the
>>> list, it fires once, but if you type "0" directly in the box, it fires
>>> twice. I already tried disabling events before my code and re-
>>> enabling them after it runs, but that did not work. Any help would be
>>> appreciated.
>>>
>>> Thanks!

>>

>
>

Use combobox click event instead of change event. I struggled with this for three days and I was able to solve it.

Marooned
 
Ad

Advertisements

Joined
Jun 20, 2012
Messages
2
Reaction score
0
Use combobox click event instead of change event. I struggled with this for three days and I was able to solve it. It appears that change event has an inbuilt error. Though the original post is very old I thought somebody may be looking for a solution like I did 3 days ago. I am not a trained programmer, but I write program as a hobby.:D

Marooned
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Top