Code Improvement

  • Thread starter Thread starter Guest
  • Start date Start date
G

Guest

Hi

I have the ffg cade to enter data to a sheet. It works fine but how can i
improve it as to shorten it.......

Sub ActualAdd()
ActiveCell.FormulaR1C1 = frmMain.txt2.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt3.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt4.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt5.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt6.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt7.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt8.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt9.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt10.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt11.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt12.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt13.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt14.Text
ActiveCell.Offset(0, 1).Select
ActiveCell.FormulaR1C1 = frmMain.txt15.Text

Range("A3").Select
Selection.CurrentRegion.Select
Selection.Name = "CustomerInfo"
Selection.HorizontalAlignment = xlLeft
Selection.Sort Key1:=Range("A3"), Order1:=xlAscending, Header:=xlGuess, _
OrderCustom:=1, MatchCase:=False, Orientation:=xlTopToBottom, _
DataOption1:=xlSortNormal


End Sub

Thanx
 
Zaahir,

here's one suggestion.

Sub ActualAdd()
Dim c As Range
Dim i As Integer

Set c = ActiveCell
For i = 2 To 15
c.FormulaR1C1 = frmMain.Controls("txt" & i).Text
Set c = c.Offset(0, 1)
Next i

With Range("A3").CurrentRegion
.Name = "CustomerInfo"
.HorizontalAlignment = xlLeft
.Sort Key1:=Range("A3"), Order1:=xlAscending, Header:=xlGuess, _
OrderCustom:=1, MatchCase:=False, Orientation:=xlTopToBottom, _
DataOption1:=xlSortNormal
End With

End Sub
 
wow...excellent.
thanx stax Vergel

Vergel Adriano said:
Zaahir,

here's one suggestion.

Sub ActualAdd()
Dim c As Range
Dim i As Integer

Set c = ActiveCell
For i = 2 To 15
c.FormulaR1C1 = frmMain.Controls("txt" & i).Text
Set c = c.Offset(0, 1)
Next i

With Range("A3").CurrentRegion
.Name = "CustomerInfo"
.HorizontalAlignment = xlLeft
.Sort Key1:=Range("A3"), Order1:=xlAscending, Header:=xlGuess, _
OrderCustom:=1, MatchCase:=False, Orientation:=xlTopToBottom, _
DataOption1:=xlSortNormal
End With

End Sub
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Similar Threads

Create Detail Sheets from Pivot Table 1
Need help with rounding in VBA code 4
Wrong code? 3
Slow Procedure 5
cell select 4
Help Debugging VB Code 6
Formatting cells with VB 1
How to write a vba loop for Excel 1

Back
Top