code does not copy

W

Wanna Learn

Hello I inherited a workbook from someone that is no longer here. I
modified the workbook then I copied the code below from the Ron De Bruin
site. Problem is that it does no copy the formulas as values. Where there
was a formulas I get #NA .
formula on cells look something like this =IF(ISNA(MATCH(A100,'2008
Story'!REF))," ",(VLOOKUP(A100,'2008 Story'!$A:$C,3,FALSE))) thanks a
million

THis is the code
Sub Mail_ActiveSheet()
'Working in 2000-2007
Dim FileExtStr As String
Dim FileFormatNum As Long
Dim Sourcewb As Workbook
Dim Destwb As Workbook
Dim TempFilePath As String
Dim TempFileName As String
Dim OutApp As Object
Dim OutMail As Object

With Application
..ScreenUpdating = False
..EnableEvents = False
End With

Set Sourcewb = ActiveWorkbook

'Copy the sheet to a new workbook
ActiveSheet.Copy
Set Destwb = ActiveWorkbook

'Determine the Excel version and file extension/format
With Destwb
If Val(Application.Version) < 12 Then
'You use Excel 2000-2003
FileExtStr = ".xls": FileFormatNum = -4143
Else
'You use Excel 2007
'We exit the sub when your answer is NO in the security dialog
that you only
'see when you copy a sheet from a xlsm file with macro's
disabled.
If Sourcewb.Name = .Name Then
With Application
..ScreenUpdating = True
..EnableEvents = True
End With
MsgBox "Your answer is NO in the security dialog"
Exit Sub
Else
Select Case Sourcewb.FileFormat
Case 51: FileExtStr = ".xlsx": FileFormatNum = 51
Case 52:
If .HasVBProject Then
FileExtStr = ".xlsm": FileFormatNum = 52
Else
FileExtStr = ".xlsx": FileFormatNum = 51
End If
Case 56: FileExtStr = ".xls": FileFormatNum = 56
Case Else: FileExtStr = ".xlsb": FileFormatNum = 50
End Select
End If
End If
End With

' 'Change all cells in the worksheet to values if you want
With Destwb.Sheets(1).UsedRange
..Cells.Copy
..Cells.PasteSpecial xlPasteValues
..Cells(1).Select
End With
'Application.CutCopyMode = False

'Save the new workbook/Mail it/Delete it
TempFilePath = Environ$("temp") & "\"
TempFileName = "Part of " & Sourcewb.Name & " " & Format(Now, "dd-mmm-yy
h-mm-ss")

Set OutApp = CreateObject("Outlook.Application")
OutApp.Session.Logon
Set OutMail = OutApp.CreateItem(0)

With Destwb
..SaveAs TempFilePath & TempFileName & FileExtStr,
FileFormat:=FileFormatNum
On Error Resume Next
With OutMail
..To = ""
..CC = ""
..BCC = ""
..Subject = " "
..Body = "Hi there"
..Attachments.Add Destwb.FullName
'You can add other files also like this
'.Attachments.Add ("C:\test.txt")
..Display 'Send 'or use .Display
End With
On Error GoTo 0
..Close SaveChanges:=False
End With

'Delete the file you have send
Kill TempFilePath & TempFileName & FileExtStr

Set OutMail = Nothing
Set OutApp = Nothing

With Application
..ScreenUpdating = True
..EnableEvents = True
End With
End Sub
 
D

Dave Peterson

So it really converts the formula to a value--but that value is #n/a?

I think I'd go back to the original source and fix those formulas:

=IF(ISNA(MATCH(A100,'2008 Story'!REF))," ",
VLOOKUP(A100,'2008 Story'!$A:$C,3,FALSE))

It looks like this formula should be:

=IF(ISNA(MATCH(A100,'2008 Story'!$a:$a,0)),"",
VLOOKUP(A100,'2008 Story'!$A:$C,3,FALSE))

I betting that that Ref was really a reference error (#Ref!). Since this error
isn't #N/A, then the else part of your if/then/else formula will be evaluated.
And there is no match, so you see #n/a.

I changed the =match() portion to look at column A for an exact match (that's
what that 0 in the 3rd argument means).

I also changed the " " (with a single space) to "" (no space).
 
W

Wanna Learn

Dave You are a genius! Thank you so much.

Dave Peterson said:
So it really converts the formula to a value--but that value is #n/a?

I think I'd go back to the original source and fix those formulas:

=IF(ISNA(MATCH(A100,'2008 Story'!REF))," ",
VLOOKUP(A100,'2008 Story'!$A:$C,3,FALSE))

It looks like this formula should be:

=IF(ISNA(MATCH(A100,'2008 Story'!$a:$a,0)),"",
VLOOKUP(A100,'2008 Story'!$A:$C,3,FALSE))

I betting that that Ref was really a reference error (#Ref!). Since this error
isn't #N/A, then the else part of your if/then/else formula will be evaluated.
And there is no match, so you see #n/a.

I changed the =match() portion to look at column A for an exact match (that's
what that 0 in the 3rd argument means).

I also changed the " " (with a single space) to "" (no space).
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Top