Canceling a read file function

[mwc0914]

I have a macro where the user is required to select a file to open. This
is done via the Windows Open File dialog box. If they elect to "cancel"
and not open the file, I get an error. I know there must be some coding
I can put into my macro to trap this and just exit the macro if this
happens.

Thanks
Mike

 

[Guest]

On Error GoTo Cancel

 

[Guest]

Sorry I forgot to paste the line:

CommonDialog1.CancelError = True

before:

 

[Ron de Bruin]

hi Mike

Use GetOpenFilename

Sub test()
Dim FName As Variant
Dim wb As Workbook
Dim MyPath As String
Dim SaveDriveDir As String

SaveDriveDir = CurDir

MyPath = ThisWorkbook.Path
ChDrive MyPath
ChDir MyPath

FName = Application.GetOpenFilename(filefilter:="Excel Files (*.xls), *.xls")
If FName <> False Then
Set wb = Workbooks.Open(FName)
MsgBox "your code"
wb.Close
End If

ChDrive SaveDriveDir
ChDir SaveDriveDir

End Sub

 

[mwc0914]

Tired it but am getting False.xls not defined error. My code is...

 

[Guest]

Application.GetOpenFilename, nice! I didn't know about that function. I was
surprised I didn't need to use quotes here:

If FName <> "False" Then

hi Mike

Use GetOpenFilename

Sub test()
Dim FName As Variant
Dim wb As Workbook
Dim MyPath As String
Dim SaveDriveDir As String

SaveDriveDir = CurDir

MyPath = ThisWorkbook.Path
ChDrive MyPath
ChDir MyPath

FName = Application.GetOpenFilename(filefilter:="Excel Files (*.xls), *.xls")
If FName <> False Then
Set wb = Workbooks.Open(FName)
MsgBox "your code"
wb.Close
End If

ChDrive SaveDriveDir
ChDir SaveDriveDir

End Sub

 

[Ron de Bruin]

Not use "False"

You get problems when you run the code on a Dutch machine or other language

See Stephen's site
http://www.oaltd.co.uk/ExcelProgRef/Default.htm

Click on "International Issues"


--
Regards Ron De Bruin
http://www.rondebruin.nl

Application.GetOpenFilename, nice! I didn't know about that function. I was
surprised I didn't need to use quotes here:

If FName <> "False" Then

 

[mwc0914]

I got it working with the following code...