best way to log exceptions

[Guest]

Hi,

I have a class called Loger that has only a static method:

public class Logger
{
public static void LogException (Exception e)
{
//code to write the exception into a text file...
}
}

I have, for other hand a group of classes that does some operations and i
would like to log every exception inside each class.

Its a good way to call this static method every time the code execute a
catch statement?

for instance:

try
{
//do something
}
catch (Exception e)
{
Logger.LogException(e);
}

What do you think about it?

 

[john doe]

Have you looked at http://logging.apache.org/log4net/

 

[Ignacio Machin \( .NET/ C# MVP \)]

Hi,

It's simple and useful way, I do it in more than one project , you could
select to either write it to a file ( as you do ) or to an Event Log .

Also take a look into the Exception app block from MS:

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dnpag2/html/ehab.asp

Cheers,

 

[Joe Jax]

Also take a look into the Exception app block from MS:

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dnpag2/html/ehab.asp

I personally think the MS app blocks are junk. There is just too much code
in there and it can't all be useful. Most times the easy and transparent
approach is best. If you can achieve in one or two lines what someone else
has done in 10000 lines, consider the possiblity that your way is best.

 

[Bruce Wood]

While this doesn't directly bear on your question... IMHO logging
exceptions from catch blocks is often bad style.

The very fact that you're catching an exception means that your
application can somehow deal with it and keep going. If you have some
sort of application that has to keep running "no matter what," then
try...catch... log exception may be a reasonable approach. Nonetheless,
in most applications the very fact that you chose to catch an exception
means that, in some sense, you "know what to do about it," and
therefore why bother logging what you've successfully dealt with?

If you want to report all fatal exceptions in your application so that
they're logged in one place (so that users don't have to report the
gory details themselves), try looking at the
AppDomain.UnhandledException and Thread.ThreadException events. Let any
exceptions you don't know how to handle bubble up the stack until they
raise one of these events, and log them there.