Another try - inserting datset into sql

G

Guest

NEW Post

Here's my best guess at how to insert this dataset....
the code runs, but no new records are added to the sql table.

I've read and split a delimited text file into a dataset.
It looks fine in a datagrid (5 columns and 5,000 rows),
but I've been trying, without success, to then insert
the resulting dataset called "result" into a single sql
table that has an auto-increment and PK column called ID,
as well as the 5 columns from the dataset.

Any suggestions on a way to perform the insert of the
"result" dataset into the sql table?

Thanks,

Paul

==================================================================================================


StreamReader sr = new StreamReader("C:\\test.txt"); //Read From A
File instead of a webrequest

DataSet result = new DataSet(); //The DataSet to Return
result.Tables.Add("MyNewTable"); //Add DataTable to hold the DataSet

result.Tables["MyNewTable"].Columns.Add("CompanyName"); //Add a single
column to the DataTable
result.Tables["MyNewTable"].Columns.Add("FormType"); //Add a single
column
result.Tables["MyNewTable"].Columns.Add("CIK"); //Add a single
column
result.Tables["MyNewTable"].Columns.Add("DateFiled"); //Add a single
column
result.Tables["MyNewTable"].Columns.Add("SECWebAddress"); //Add a single
column

string AllData1 = sr.ReadToEnd(); //Read the rest of the
data in the file.
string[] rows = AllData1.Split("\n".ToCharArray()); //Split off each
row at the Line Feed

foreach(string r in rows) //Now add each row to the
DataSet
{
string delimStr1 = "\t";
string[] items = r.Split(delimStr1.ToCharArray()); //Split the row at the
delimiter
result.Tables["MyNewTable"].Rows.Add(items); //Add the item
}

for (int i = 1; i <= 11; i++) //Remove first 8
rows from the DataTable/DataSet
{
result.Tables["MyNewTable"].Rows.RemoveAt(0);
}

dataGrid1.SetDataBinding(result, "MyNewTable"); //Binds DataGrid to
DataSet,displaying datatable

SqlDataAdapter sqlDataAdapter1 = new SqlDataAdapter(); //Configure a
data adapter

//Configure the SQL connection
SqlConnection sqlConnection1 = new SqlConnection("workstation id=AMD;packet
size=4096;" +
"integrated security=SSPI;data source=AMD;persist security
info=False;initial catalog=SEC_XBRL_10");

//Generate the 'INSERT' command
SqlCommand sqlInsertCommand1 = new SqlCommand("INSERT INTO
SEC_Index_01(CompanyName, FormType, CIK, " +
"DateFiled, SECWebAddress) VALUES (@CompanyName, @FormType, @CIK,
@DateFiled, @FileName); SELECT ID, " +
"CompanyName, FormType, CIK, DateFiled, SECWebAddress FROM SEC_Index_01
WHERE (ID = @@IDENTITY)", sqlConnection1);

//Add the parameters
sqlInsertCommand1.Parameters.Add("@CompanyName",
System.Data.SqlDbType.VarChar, 8000, "CompanyName");
sqlInsertCommand1.Parameters.Add("@FormType", System.Data.SqlDbType.VarChar,
8000, "FormType");
sqlInsertCommand1.Parameters.Add("@CIK", System.Data.SqlDbType.VarChar,
8000, "CIK");
sqlInsertCommand1.Parameters.Add("@DateFiled",
System.Data.SqlDbType.VarChar, 8000, "DateFiled");
sqlInsertCommand1.Parameters.Add("@FileName", System.Data.SqlDbType.VarChar,
8000, "SECWebAddress");


sqlDataAdapter1.InsertCommand = sqlInsertCommand1; //Set the insert
command

sqlDataAdapter1.Update(result,"SEC_Index_01"); //Perform the
update
 
W

W.G. Ryan eMVP

First off, check the Rowstate of the rows in question or test the dataset
with Debug.Assert(myDataSet.HasChanges());

If this is false or the rowstate of everything is unchanged, then no matter
how many times you call update, nothing will happen. A typical mistake taht
causes this is calling AcceptChanges on the rows or the dataset sometime
before calling Update.

Next, you'll need to check your update command and make sure that it's valid
and that the column mappings are correct and the parameters all match. For
instance, if you hard coded an insert statement without parameters as your
adapter's insert command, it will fire each time a Row with a rowstate of
inserted is found - but since you hard coded the values, it won't
dynamically change the values its inserting

If you could post the code it would probably help to narrow things down.

--
W.G. Ryan, MVP

www.tibasolutions.com | www.devbuzz.com | www.knowdotnet.com
a said:
NEW Post

Here's my best guess at how to insert this dataset....
the code runs, but no new records are added to the sql table.

I've read and split a delimited text file into a dataset.
It looks fine in a datagrid (5 columns and 5,000 rows),
but I've been trying, without success, to then insert
the resulting dataset called "result" into a single sql
table that has an auto-increment and PK column called ID,
as well as the 5 columns from the dataset.

Any suggestions on a way to perform the insert of the
"result" dataset into the sql table?

Thanks,

Paul

============================================================================
======================


StreamReader sr = new StreamReader("C:\\test.txt"); //Read From A
File instead of a webrequest

DataSet result = new DataSet(); //The DataSet to Return
result.Tables.Add("MyNewTable"); //Add DataTable to hold the DataSet

result.Tables["MyNewTable"].Columns.Add("CompanyName"); //Add a single
column to the DataTable
result.Tables["MyNewTable"].Columns.Add("FormType"); //Add a single
column
result.Tables["MyNewTable"].Columns.Add("CIK"); //Add a single
column
result.Tables["MyNewTable"].Columns.Add("DateFiled"); //Add a single
column
result.Tables["MyNewTable"].Columns.Add("SECWebAddress"); //Add a single
column

string AllData1 = sr.ReadToEnd(); //Read the rest of the
data in the file.
string[] rows = AllData1.Split("\n".ToCharArray()); //Split off each
row at the Line Feed

foreach(string r in rows) //Now add each row to the
DataSet
{
string delimStr1 = "\t";
string[] items = r.Split(delimStr1.ToCharArray()); //Split the row at the
delimiter
result.Tables["MyNewTable"].Rows.Add(items); //Add the item
}

for (int i = 1; i <= 11; i++) //Remove first 8
rows from the DataTable/DataSet
{
result.Tables["MyNewTable"].Rows.RemoveAt(0);
}

dataGrid1.SetDataBinding(result, "MyNewTable"); //Binds DataGrid to
DataSet,displaying datatable

SqlDataAdapter sqlDataAdapter1 = new SqlDataAdapter(); //Configure a
data adapter

//Configure the SQL connection
SqlConnection sqlConnection1 = new SqlConnection("workstation id=AMD;packet
size=4096;" +
"integrated security=SSPI;data source=AMD;persist security
info=False;initial catalog=SEC_XBRL_10");

//Generate the 'INSERT' command
SqlCommand sqlInsertCommand1 = new SqlCommand("INSERT INTO
SEC_Index_01(CompanyName, FormType, CIK, " +
"DateFiled, SECWebAddress) VALUES (@CompanyName, @FormType, @CIK,
@DateFiled, @FileName); SELECT ID, " +
"CompanyName, FormType, CIK, DateFiled, SECWebAddress FROM SEC_Index_01
WHERE (ID = @@IDENTITY)", sqlConnection1);

//Add the parameters
sqlInsertCommand1.Parameters.Add("@CompanyName",
System.Data.SqlDbType.VarChar, 8000, "CompanyName");
sqlInsertCommand1.Parameters.Add("@FormType", System.Data.SqlDbType.VarChar,
8000, "FormType");
sqlInsertCommand1.Parameters.Add("@CIK", System.Data.SqlDbType.VarChar,
8000, "CIK");
sqlInsertCommand1.Parameters.Add("@DateFiled",
System.Data.SqlDbType.VarChar, 8000, "DateFiled");
sqlInsertCommand1.Parameters.Add("@FileName", System.Data.SqlDbType.VarChar,
8000, "SECWebAddress");


sqlDataAdapter1.InsertCommand = sqlInsertCommand1; //Set the insert
command

sqlDataAdapter1.Update(result,"SEC_Index_01"); //Perform the
update
Click to expand...
 
G

Guest

That IS the code below the double dashed line...so what did i leave out?

What's the simplest way to insert new rows from the dataset that I've
created here into an existing sql table, with a dataadapter or can I just
loop through the dataset somehow and append the rows to the sql table.

I don't need anything fancy here, like validating or checking the existing
rows
against the new rows that I'm trying to insert

Thanks,

Paul
----------------------------------------------------------------

W.G. Ryan eMVP said:
First off, check the Rowstate of the rows in question or test the dataset
with Debug.Assert(myDataSet.HasChanges());

If this is false or the rowstate of everything is unchanged, then no matter
how many times you call update, nothing will happen. A typical mistake taht
causes this is calling AcceptChanges on the rows or the dataset sometime
before calling Update.

Next, you'll need to check your update command and make sure that it's valid
and that the column mappings are correct and the parameters all match. For
instance, if you hard coded an insert statement without parameters as your
adapter's insert command, it will fire each time a Row with a rowstate of
inserted is found - but since you hard coded the values, it won't
dynamically change the values its inserting

If you could post the code it would probably help to narrow things down.

--
W.G. Ryan, MVP

www.tibasolutions.com | www.devbuzz.com | www.knowdotnet.com
a said:
NEW Post

Here's my best guess at how to insert this dataset....
the code runs, but no new records are added to the sql table.

I've read and split a delimited text file into a dataset.
It looks fine in a datagrid (5 columns and 5,000 rows),
but I've been trying, without success, to then insert
the resulting dataset called "result" into a single sql
table that has an auto-increment and PK column called ID,
as well as the 5 columns from the dataset.

Any suggestions on a way to perform the insert of the
"result" dataset into the sql table?

Thanks,

Paul

============================================================================
======================


StreamReader sr = new StreamReader("C:\\test.txt"); //Read From A
File instead of a webrequest

DataSet result = new DataSet(); //The DataSet to Return
result.Tables.Add("MyNewTable"); //Add DataTable to hold the DataSet

result.Tables["MyNewTable"].Columns.Add("CompanyName"); //Add a single
column to the DataTable
result.Tables["MyNewTable"].Columns.Add("FormType"); //Add a single
column
result.Tables["MyNewTable"].Columns.Add("CIK"); //Add a single
column
result.Tables["MyNewTable"].Columns.Add("DateFiled"); //Add a single
column
result.Tables["MyNewTable"].Columns.Add("SECWebAddress"); //Add a single
column

string AllData1 = sr.ReadToEnd(); //Read the rest of the
data in the file.
string[] rows = AllData1.Split("\n".ToCharArray()); //Split off each
row at the Line Feed

foreach(string r in rows) //Now add each row to the
DataSet
{
string delimStr1 = "\t";
string[] items = r.Split(delimStr1.ToCharArray()); //Split the row at the
delimiter
result.Tables["MyNewTable"].Rows.Add(items); //Add the item
}

for (int i = 1; i <= 11; i++) //Remove first 8
rows from the DataTable/DataSet
{
result.Tables["MyNewTable"].Rows.RemoveAt(0);
}

dataGrid1.SetDataBinding(result, "MyNewTable"); //Binds DataGrid to
DataSet,displaying datatable

SqlDataAdapter sqlDataAdapter1 = new SqlDataAdapter(); //Configure a
data adapter

//Configure the SQL connection
SqlConnection sqlConnection1 = new SqlConnection("workstation id=AMD;packet
size=4096;" +
"integrated security=SSPI;data source=AMD;persist security
info=False;initial catalog=SEC_XBRL_10");

//Generate the 'INSERT' command
SqlCommand sqlInsertCommand1 = new SqlCommand("INSERT INTO
SEC_Index_01(CompanyName, FormType, CIK, " +
"DateFiled, SECWebAddress) VALUES (@CompanyName, @FormType, @CIK,
@DateFiled, @FileName); SELECT ID, " +
"CompanyName, FormType, CIK, DateFiled, SECWebAddress FROM SEC_Index_01
WHERE (ID = @@IDENTITY)", sqlConnection1);

//Add the parameters
sqlInsertCommand1.Parameters.Add("@CompanyName",
System.Data.SqlDbType.VarChar, 8000, "CompanyName");
sqlInsertCommand1.Parameters.Add("@FormType", System.Data.SqlDbType.VarChar,
8000, "FormType");
sqlInsertCommand1.Parameters.Add("@CIK", System.Data.SqlDbType.VarChar,
8000, "CIK");
sqlInsertCommand1.Parameters.Add("@DateFiled",
System.Data.SqlDbType.VarChar, 8000, "DateFiled");
sqlInsertCommand1.Parameters.Add("@FileName", System.Data.SqlDbType.VarChar,
8000, "SECWebAddress");


sqlDataAdapter1.InsertCommand = sqlInsertCommand1; //Set the insert
command

sqlDataAdapter1.Update(result,"SEC_Index_01"); //Perform the
update
Click to expand...
Click to expand...
 
R

Ron Allen

Paul,
Does this throw an exception? You are retrieving the ID field and there
is no column to put that data into so I would expect some kind of error
there. Also do your column definitions in the database match the ones for
your parameters? If you are using SQL2K I'd also think you want
SCOPE_IDENTITY() instead of @@Identity.

Ron Allen
a said:
NEW Post

Here's my best guess at how to insert this dataset....
the code runs, but no new records are added to the sql table.

I've read and split a delimited text file into a dataset.
It looks fine in a datagrid (5 columns and 5,000 rows),
but I've been trying, without success, to then insert
the resulting dataset called "result" into a single sql
table that has an auto-increment and PK column called ID,
as well as the 5 columns from the dataset.

Any suggestions on a way to perform the insert of the
"result" dataset into the sql table?

Thanks,

Paul

==================================================================================================


StreamReader sr = new StreamReader("C:\\test.txt"); //Read From A
File instead of a webrequest

DataSet result = new DataSet(); //The DataSet to Return
result.Tables.Add("MyNewTable"); //Add DataTable to hold the DataSet

result.Tables["MyNewTable"].Columns.Add("CompanyName"); //Add a single
column to the DataTable
result.Tables["MyNewTable"].Columns.Add("FormType"); //Add a single
column
result.Tables["MyNewTable"].Columns.Add("CIK"); //Add a single
column
result.Tables["MyNewTable"].Columns.Add("DateFiled"); //Add a single
column
result.Tables["MyNewTable"].Columns.Add("SECWebAddress"); //Add a single
column

string AllData1 = sr.ReadToEnd(); //Read the rest of the
data in the file.
string[] rows = AllData1.Split("\n".ToCharArray()); //Split off
each
row at the Line Feed

foreach(string r in rows) //Now add each row to the
DataSet
{
string delimStr1 = "\t";
string[] items = r.Split(delimStr1.ToCharArray()); //Split the row at the
delimiter
result.Tables["MyNewTable"].Rows.Add(items); //Add the item
}

for (int i = 1; i <= 11; i++) //Remove first
8
rows from the DataTable/DataSet
{
result.Tables["MyNewTable"].Rows.RemoveAt(0);
}

dataGrid1.SetDataBinding(result, "MyNewTable"); //Binds DataGrid to
DataSet,displaying datatable

SqlDataAdapter sqlDataAdapter1 = new SqlDataAdapter(); //Configure a
data adapter

//Configure the SQL connection
SqlConnection sqlConnection1 = new SqlConnection("workstation
id=AMD;packet
size=4096;" +
"integrated security=SSPI;data source=AMD;persist security
info=False;initial catalog=SEC_XBRL_10");

//Generate the 'INSERT' command
SqlCommand sqlInsertCommand1 = new SqlCommand("INSERT INTO
SEC_Index_01(CompanyName, FormType, CIK, " +
"DateFiled, SECWebAddress) VALUES (@CompanyName, @FormType, @CIK,
@DateFiled, @FileName); SELECT ID, " +
"CompanyName, FormType, CIK, DateFiled, SECWebAddress FROM SEC_Index_01
WHERE (ID = @@IDENTITY)", sqlConnection1);

//Add the parameters
sqlInsertCommand1.Parameters.Add("@CompanyName",
System.Data.SqlDbType.VarChar, 8000, "CompanyName");
sqlInsertCommand1.Parameters.Add("@FormType",
System.Data.SqlDbType.VarChar,
8000, "FormType");
sqlInsertCommand1.Parameters.Add("@CIK", System.Data.SqlDbType.VarChar,
8000, "CIK");
sqlInsertCommand1.Parameters.Add("@DateFiled",
System.Data.SqlDbType.VarChar, 8000, "DateFiled");
sqlInsertCommand1.Parameters.Add("@FileName",
System.Data.SqlDbType.VarChar,
8000, "SECWebAddress");


sqlDataAdapter1.InsertCommand = sqlInsertCommand1; //Set the
insert
command

sqlDataAdapter1.Update(result,"SEC_Index_01"); //Perform the
update
Click to expand...
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Similar Threads

Error when adding array to datatable 2
Add array to a datatable 3
Newbie Update, Insert, & Delete Using Visual Studio And TextBoxes 2
Millisecond values missing when inserting datetime into datetime column of sql Server 4
Issue with Databinding. 11
Problem Binding to DataGrid 2
Another DataGrid Sorting problem 3
Inserting records from one database into identical table in another datrabase 7

Top