property assignment in vb.net

[Guest]

My first simple attempt at using a property. and I get an exception "An
unhandled exception of type 'System.StackOverflowException' occurred in
BalanceOmatic.exe" on line xxx. I have included the property code and the
button event used to set and call the property value. Any help greatly
appreciated.



What am I missing?

Thanks
Mike


Private Sub btnLogin_Click(ByVal sender As System.Object, ByVal e As
System.EventArgs) Handles btnLogin.Click

User.MyProperty = "Property Set"

MsgBox(User.MyProperty & " User.MyProperty")

End Sub


Public Property MyProperty() As String
Get
MyProperty = MyProperty
End Get
Set(ByVal Value As String)
Line xxx MyProperty = Value
End Set
End Property

 

[Marina]

Your property is recursive. Instead of setting a private variable, you are
just assigning the value to the property itself - which just calls it over
and over again.

Your GET btw, could only return a boolean of whether or not the property is
equal to itself. Not only will this recursively call itself until you get a
StackOverflowException, but the return of that would actually be a Boolean
(if it was capable of ever ending), and not a string at all. Which means you
should turn Option Strict On.

You need to define your property like this:

private _myProp As String

Public Property MyProperty() As String
Get
Return _myProp
End Get
Set(ByVal Value As String)
_myProp = Value
End Set
End Property

 

[Guest]

The following line is causing the stack overflow because the property is
calling itself (infinite recursion):

MyProperty = MyProperty

You need to create an underlying variable for the property to hold the value
of the property. The example at the bottom of the following link shows you
exactly how to do this:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vblr7/html/vastmproperty.asp

HTH, Jakob.

 

[Guest]

I presume User is a class? although its not that relevant if it isnt.

have you dim'd a private variable to hold the properties value?

The 'Get' is coded incorrectly, it should return the private variables
contents!

Hope this helps. See below for code changes



PRIVATE _myProperty as string

 

[Guest]

Thanks for the reply. That was it of course. One more quick question. Why
the underscore in _myProp is that a property convention?

Thanks
Mike

 

[Marina]

The only reason I did that, is because VB is case insensitive. In C#, you
can have a private variable named 'someProperty' and a property named
'SomeProperty', and that all works.

In VB, those would be the same name, and you can't have that. So one
convention is to give private fields exposed as properties an underscore, so
you can have unique names.