No Records Then

[DS]

I'm trying to run this code on the main form load event.
If the Subform has no records then the Listbox on the subform is empty
otherwisw populate the listbox with the appropriate records. It works
fine whenever there are records but when I open the main form with a new
record all of the records show in the listbox. The DCount always seems
to show how many records are there, disregarding my criteria. Any help
appreciated.
Thanks
DS




Private Sub Form_Load()
Me.Text307 = DCount("SalesID", "SalesDetails", "SalesID =
Forms!Buttons!SalesID")

If Me.Text307 = Null Then
End
Else
With Forms!Buttons.PrepSlipSub.Form!List52
.RowSource = "SELECT
LineID,ItemID,SalesID,Expr8,Expr7,Expr6,Quantity,Expr5,Expr4,ItemType" _
& " FROM PrepSlipQ " _
& " WHERE SalesID = " & Forms!Buttons.PrepSlipSub.Form!SalesID
& "" _
& " ORDER BY LineID,ItemType ASC;"
Forms!Buttons.PrepSlipSub.Form!List52.Requery
End With
End If
End Sub

 

[DS]

I'm trying to run this code on the main form load event.
If the Subform has no records then the Listbox on the subform is empty
otherwisw populate the listbox with the appropriate records. It works
fine whenever there are records but when I open the main form with a new
record all of the records show in the listbox. The DCount always seems
to show how many records are there, disregarding my criteria. Any help
appreciated.
Thanks
DS




Private Sub Form_Load()
Me.Text307 = DCount("SalesID", "SalesDetails", "SalesID =
Forms!Buttons!SalesID")

If Me.Text307 = Null Then
End
Else
With Forms!Buttons.PrepSlipSub.Form!List52
.RowSource = "SELECT
LineID,ItemID,SalesID,Expr8,Expr7,Expr6,Quantity,Expr5,Expr4,ItemType" _
& " FROM PrepSlipQ " _
& " WHERE SalesID = " & Forms!Buttons.PrepSlipSub.Form!SalesID &
"" _
& " ORDER BY LineID,ItemType ASC;"
Forms!Buttons.PrepSlipSub.Form!List52.Requery
End With
End If
End Sub

I did this instead and it works fine!
DS

Private Sub Form_Load()
If Me![PrepSlipSub].Form.RecordsetClone.RecordCount > 0 Then
With Forms!Buttons.PrepSlipSub.Form!List52
.RowSource = "SELECT
LineID,ItemID,SalesID,Expr8,Expr7,Expr6,Quantity,Expr5,Expr4,ItemType" _
& " FROM PrepSlipQ " _
& " WHERE SalesID = " & Forms!Buttons.PrepSlipSub.Form!SalesID
& "" _
& " ORDER BY LineID,ItemType ASC;"
Forms!Buttons.PrepSlipSub.Form!List52.Requery
End With
Else
Forms!Buttons.PrepSlipSub.Form!List52 = Null
End If

End Sub

 

[Guest]

I'm trying to run this code on the main form load event.
If the Subform has no records then the Listbox on the subform is empty
otherwisw populate the listbox with the appropriate records. It works
fine whenever there are records but when I open the main form with a new
record all of the records show in the listbox. The DCount always seems
to show how many records are there, disregarding my criteria. Any help
appreciated.
Thanks
DS




Private Sub Form_Load()
Me.Text307 = DCount("SalesID", "SalesDetails", "SalesID =
Forms!Buttons!SalesID")

If Me.Text307 = Null Then
End
Else
With Forms!Buttons.PrepSlipSub.Form!List52
.RowSource = "SELECT
LineID,ItemID,SalesID,Expr8,Expr7,Expr6,Quantity,Expr5,Expr4,ItemType" _
& " FROM PrepSlipQ " _
& " WHERE SalesID = " & Forms!Buttons.PrepSlipSub.Form!SalesID
& "" _
& " ORDER BY LineID,ItemType ASC;"
Forms!Buttons.PrepSlipSub.Form!List52.Requery
End With
End If
End Sub

 

[Guest]

First problem is a syntax issue:
If Me.Text307 = Null Then
Should be:
If IsNull(Me.Text307) Then

I am not a big fan of the End statement. The problem with it is that it
clears all module level variables and any local static variables. This could
cause an unexpected problem. Here is how I would code it:
If Not IsNull(Me.Text307) Then
With Forms!Buttons.PrepSlipSub.Form!List52
.RowSource = "SELECT
LineID,ItemID,SalesID,Expr8,Expr7,Expr6,Quantity,Expr5,Expr4,ItemType" _
& " FROM PrepSlipQ " _
& " WHERE SalesID = " & Forms!Buttons.PrepSlipSub.Form!SalesID
& "" _
& " ORDER BY LineID,ItemType ASC;"
Forms!Buttons.PrepSlipSub.Form!List52.Requery
End With
End If

 

[DS]

First problem is a syntax issue:
If Me.Text307 = Null Then
Should be:
If IsNull(Me.Text307) Then

I am not a big fan of the End statement. The problem with it is that it
clears all module level variables and any local static variables. This could
cause an unexpected problem. Here is how I would code it:
If Not IsNull(Me.Text307) Then
With Forms!Buttons.PrepSlipSub.Form!List52
.RowSource = "SELECT
LineID,ItemID,SalesID,Expr8,Expr7,Expr6,Quantity,Expr5,Expr4,ItemType" _
& " FROM PrepSlipQ " _
& " WHERE SalesID = " & Forms!Buttons.PrepSlipSub.Form!SalesID
& "" _
& " ORDER BY LineID,ItemType ASC;"
Forms!Buttons.PrepSlipSub.Form!List52.Requery
End With
End If

:

Thank you, to the rescue once more!
Sincerely
DS