Copy all data into one sheet and insert origin data... code amend...

[harteorama]

Hi all,

Can anybody please help, i have some code (below) that copies all of
my data in all sheets into a master. Is there a way to put the sheet
name in Col B next to the copied data so i can see where it came from?

Many thanks in advance,

Cheers

P

Sub CopyFromWorksheets()
Dim wrk As Workbook 'Workbook object - Always good to work with
object variables
Dim sht As Worksheet 'Object for handling worksheets in loop
Dim trg As Worksheet 'Master Worksheet
Dim rng As Range 'Range object
Dim colCount As Integer 'Column count in tables in the worksheets

Set wrk = ActiveWorkbook 'Working in active workbook

For Each sht In wrk.Worksheets
If sht.Name = "Master" Then
MsgBox "There is a worksheet called as 'Master'." & vbCrLf
& _
"Please remove or rename this worksheet since 'Master'
would be" & _
"the name of the result worksheet of this process.",
vbOKOnly + vbExclamation, "Error"
Exit Sub
End If
Next sht

'We don't want screen updating
Application.ScreenUpdating = False

'Add new worksheet as the last worksheet
Set trg =
wrk.Worksheets.Add(After:=wrk.Worksheets(wrk.Worksheets.Count))
'Rename the new worksheet
trg.Name = "Master"
'Get column headers from the first worksheet
'Column count first
Set sht = wrk.Worksheets(1)
colCount = sht.Cells(1, 255).End(xlToLeft).Column
'Now retrieve headers, no copy&paste needed
With trg.Cells(1, 1).Resize(1, colCount)
.Value = sht.Cells(1, 1).Resize(1, colCount).Value
'Set font as bold
.Font.Bold = True
End With

'We can start loop
For Each sht In wrk.Worksheets
'If worksheet in loop is the last one, stop execution (it is
Master worksheet)
If sht.Index = wrk.Worksheets.Count Then
Exit For
End If
'Data range in worksheet - starts from second row as first
rows are the header rows in all worksheets
Set rng = sht.Range(sht.Cells(2, 1), sht.Cells(65536,
1).End(xlUp).Resize(, colCount))
'Put data into the Master worksheet
trg.Cells(65536, 1).End(xlUp).Offset(1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = rng.Value
Next sht
'Fit the columns in Master worksheet
trg.Columns.AutoFit

'Screen updating should be activated
Application.ScreenUpdating = True
End Sub

 

[Joel]

from
trg.Cells(65536, 1).End(xlUp).Offset(1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = rng.Value


to
trg.Cells(65536, 1).End(xlUp).Offset(1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = rng.Value
trg.Cells(65536, 1).End(xlUp).Offset(1,1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = sht.name

 

[harteorama]

Hi,

Ive tried the amendments, but, it doesnt quite work - its putting the
sheet names next to the wrong entries. i.e. i have

sheet 1

Col A
ABC112
HGF321

Sheet 2

Col A
POL008
OOL001


What is actually being copied to the Master Sheet is


Col A
ABC112
HGF321
POL008 Sheet1
OOL001 Sheet1
..... Sheet2
..... Sheet2

Hope this makes sense...

cheers

P

 

[Joel]

Try reversing the two statments.

from
trg.Cells(65536, 1).End(xlUp).Offset(1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = rng.Value
trg.Cells(65536, 1).End(xlUp).Offset(1,1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = sht.name


to
trg.Cells(65536, 1).End(xlUp).Offset(1,1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = sht.name
trg.Cells(65536, 1).End(xlUp).Offset(1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = rng.Value