2 Questions on Reading Binary File; "Conversion buffer overflow"

[poifull]

Hi All,

What is the proper way to read a binary file into a byte[]?
I am using BinaryReader to read from a Stream and call the ReadByte method
of the BinaryReader object.

The method I'm using leads to the second question. I got the "Conversion
buffer overflow" error when I run the following code:
Stream s = openFileDialog1.OpenFile();

System.IO.BinaryReader br = new BinaryReader(s);

byte[] ba = new byte[s.Length]; // s.Length ~= 20000

while (br.PeekChar() > -1) {

ba[s.Position] = br.ReadByte(); // <- s.Position ~= 400 when error
occurred

}

Thanks in advance

 

[Dave]

Try the following:

byte[] bytes = new byte[stream.Length];

stream.Position = 0;
stream.Read(bytes, 0, bytes.Length);

 

[Ignacio Machin \( .NET/ C# MVP \)]

Hi,


Take a look at this code:
int readed=0;
byte[] buff = new Byte[2048];
FileStream fstream = new FileStream( filename, FileMode.Open);

while( (readed=fstream.Read( buff, 0, 2048))>0 )
networkstream.Write( buff, 0, readed);
fstream.Close();


Cheers,

 

[Jon Skeet [C# MVP]]

byte[] bytes = new byte[stream.Length];

stream.Position = 0;
stream.Read(bytes, 0, bytes.Length);

As it stands, that's not good code - you should *always* test the
result of stream.Read, as you may not be able to read everything in one
chunk.

See http://www.pobox.com/~skeet/csharp/readbinary.html