Peer review requested....

[Larry Serflaten]

I am planning to share a Cards.DLL out on Planet Source Code
and GotDotNet. But before I send it out to the public I would
like to get a peer review to be sure it works as intended, and
to avoid any stupid coding tricks or other unsightly practices.

I am supplying a zipped package of just the source text and
allowing the user to build all the executables. I want to be
sure that goes as planned.

To demonstrate the Cards.DLL I have included two sample programs,
a single player poker game and a quick and dirty testing form.

There is a read me file included which explains what is needed to
get it working right off, as well as documentation for the assembly.

The main thing I want looked at is the Cards project to be sure
I am not demonstrating bad practises. I'll take any and all
critiques from any of you that have a few spare minutes to
look over the code. For your effort, you can keep the poker
game! I just want to get other's opinions to be sure there are
no glaring problems with the Cards project code before posting
it to the web sites.

The zipped package is available at:
http://www.usinternet.com/users/serflaten/dotnet/games/childsplaycards.zip
(~ 195 KB)

This was developed with version 1.1 of the .Net framework, if there
are problems with other versions, I'd like to hear about it...

Thanks!
LFS

 

[Cor Ligthert]

Hi Larry,

I have looked a little bit to your program, (Yesterday actually and what
curious what others would say before I did gave my comments)

Especially the way you make the cards was good information for me as well, I
still am thinking to make a card program myself first klaverjas (that is
ballot in french, I do not know the english name) and than bridge. The way
you make the cards was very brighten to me, while that was my major strugle,
so now I can make a new start with that again.

What I do not understand (while it is working nice) is why you did not go
for a shared class but for a module (however I see reasons).

As last, the desk is a little bit small on a desktop with smaller dots, I
would make it dynamic so that people who want to play it at office can hide
it directly for there boss and older ones at home have a simple look at it.

I did not check if your logic was working.
For a poker game I would make it more in real, with bidding and have the
change to go away and the possibility to ask for seeing, now it is for me
more a kind of black jack with a poker system.

I hope this helps?

Cor

 

[Larry Serflaten]

Hi Larry,

I have looked a little bit to your program, (Yesterday actually and what
curious what others would say before I did gave my comments)

Thank you for sending your comments. replies inline:

Especially the way you make the cards was good information for me as well, I
still am thinking to make a card program myself first klaverjas (that is
ballot in french, I do not know the english name) and than bridge. The way
you make the cards was very brighten to me, while that was my major strugle,
so now I can make a new start with that again.

Good! Does that mean you will be making your own cards?

What I do not understand (while it is working nice) is why you did not go
for a shared class but for a module (however I see reasons).

Would not a shared class have the same values all the time? If a card was
shared, it could only be one value at a time. That may work for drawing
purposes, but I was thinking that, like real cards, each player would be
given a set (eg. 5 for poker) to play, and they could play those one at a time.
In other words, cards are real objects, so I naturally thought to make them
objects.

As last, the desk is a little bit small on a desktop with smaller dots,

Do you mean the poker form is a little small? Or, do you mean the cards
are small? The cards are the same size as Solitaire cards. ;-) Using the
Position property, they can be stretched to larger sizes if desired.

I would make it dynamic so that people who want to play it at office can hide
it directly for there boss and older ones at home have a simple look at it.

The poker game was a bonus just to show how the cards could be used.
A real poker game might have more options, I agree....

I did not check if your logic was working.

For a poker game I would make it more in real, with bidding and have the
change to go away and the possibility to ask for seeing, now it is for me
more a kind of black jack with a poker system.

Yes, it is not a full game, it is a demo of how a programmer can use the
Card objects.

Thanks again for your comments. Do know that I have had other comments
that I want to include in the final version. I'll post a link here when a more
complete version is posted to a website. Please keep the version you have
for yourself, thanks!

LFS

 

[Cor Ligthert]

Your poker logic I mean.

Cor