Another Problem

  • Thread starter Thread starter stupler
  • Start date Start date
S

stupler

This doesn't have anything to do with my other recent question but I'd
like to ask your help once again. If you don't know I'm new at the
whole VBA thing so if its obvious, please don't moan.
I've got a macro running that keeps displaying the same box (UserForm1)
again and again when you click the cross. When debugging it, it comes up
with this:

Code:
--------------------
Sub DealorNoDeal()
Do While Not Range("C30") = 1
If Range("D12") = 5 Then
UserForm1.Show
*End If*
Loop
Do While Not Range("C30") = 1
If Range("D12") = 8 Then
UserForm1.Show
End If
Loop
Do While Not Range("C30") = 1
If Range("D12") = 11 Then
UserForm1.Show
End If
Loop
Do While Not Range("C30") = 1
If Range("D12") = 14 Then
UserForm1.Show
End If
Loop
Do While Not Range("C30") = 1
If Range("D12") = 17 Then
UserForm1.Show
End If
Loop
Do While Not Range("C30") = 1
If Range("D12") = 20 Then
UserForm1.Show
End If
Loop
End Sub
--------------------

The first "End If" is highlighted yellow. What's wrong with the code
and is there a way you can guide me to to stop it doing itself again
and again?

And is it even possible to tell from that?
 
It will continue looping unless you change the value in C30


Do While Not Range("C30") = 1
If Range("D12") = 5 Then
UserForm1.Show
End If
Loop

And consider using CASE statement to check values od D12 and put in a single
loop


Do While Not Range("C30") = 1
Select Case Range("d12")
Case 5, 8, 11, 14, 17, 20
UserForm1.Show
'<=== add code to change C30 condition .... what does C30 contain?
End Select

Loop
 
The easy part first: The reason the debug comes up with the indicated line
yellow shows simply that that is the next line of code waiting to be run.
That is not an error (unless you are getting an error message, which I don't
think you are).

Why does the box keep reappearing? It seems to me that this loop must be
"stuck":
Do While Not Range("C30") = 1
If Range("D12") = 5 Then
UserForm1.Show
*End If*
Loop
An "endless loop" is one of the most common programming problems. You are
looping as long as Range("C30")=1. There is nothing in your code that
changes the value of C30. Perhaps there is something in your UserForm's code
that is supposed to change it but if so I would suspect from the problem you
are having that it is not changing C30. The ONLY way out of the loop is for
C30 to be equal to 1, and this must also be cell C30 on the currently active
worksheet (unless you specify otherwise, that is what Range gives you).

So the first place to check is cell C30. When you stop the code, look at
your sheet and see what is in C30 on the current active worksheet. If it is
not 1, that is the problem. Then you need to find the place where your code
should be changing C30 and find out why it isn't working.
 
Thanks everyone. You've been a huge help with this project that I'm new
at.
I was looking around for something similar to the "CODE" statement, but
couldn't find anything. Thanks for pointing it out.

I realise now that I've put the wrong number in the "Do While Not
Range("C30") = 1" bit. Thanks... again!

Seeing your comments, it all seems so obvious now! :D
 
Thanks everyone. You've been a huge help with this project that I'm ne
at.
I was looking around for something similar to the "CODE" statement, bu
couldn't find anything. Thanks for pointing it out.

Seeing your comments, it all seems so obvious now! :D

But I've come across another problem, which brings another question
Just a general one, I hope. I chose "Toppers" code to try:


Code
-------------------
Do While Not Range("C30") = 1
Select Case Range("d12")
Case 5, 8, 11, 14, 17, 20
UserForm1.Show
End Select

Loop

-------------------

-(The coding to change C30 is in UserForm1)-
but when I click the play symbol at the top of the VBA window it say
"[running]" at the top of the main window, but then freezes an
doesn't respond. Can you give me some general pointers into solving wh
it's doing that if possible? Thanks
 
Back
Top