PC Review


Reply
 
 
Bishop
Guest
Posts: n/a
 
      4th Aug 2009
I have the following code:

Option Explicit

Sub Consolidate()
Dim MyPath As String
Dim FilesInPath As String
Dim MyFiles() As String
Dim Fnum As Long
Dim mybook As Workbook
Dim CalcMode As Long
Dim sh As Worksheet
Dim ErrorYes As Boolean
Dim DCLastRow As Integer 'DirectorCopy
Dim MCLastRow As Integer 'Monthly Compiler

Dim center(18) As String
center(1) = "Bardstown"
center(2) = "Bothell"
center(3) = "VCollinsville"
center(4) = "El Paso"
center(5) = "Evansville"
center(6) = "Greensboro"
center(7) = "VHeathrow"
center(8) = "Joplin"
center(9) = "Kennesaw"
center(10) = "Lafayette"
center(11) = "Malvern"
center(12) = "VManhattan"
center(13) = "VMansfield"
center(14) = "VOttawa"
center(15) = "VPonco City"
center(16) = "VReno"
center(17) = "VSioux City"
center(18) = "VTerra Haute"

Dim FileCount As Long
Dim ScoringAve As Double
Dim i As Long


'Fill in the path\folder where the files are
MyPath = "X:\C&A Analysts Team\PF Process\1 Tally & PF's Work in
Progress\Centers\"

For i = 1 To 18

' 'Add a slash at the end if the user forget it
' If Right(MyPath, 1) <> "\" Then
' MyPath = MyPath & "\"
' End If

'If there are no Excel files in the folder exit the sub
FilesInPath = Dir(MyPath & center(i) & "*.xl*")

FileInPath is showing "" all the time. Am I using Dir wrong? Why doesn't
my path show up like I want it to? For example, if i = 2 then FilesInPath
should look like:

X:\C&A Analysts Team\PF Process\1 Tally & PF's Work in
Progress\Centers\Bothell\*.xl*
 
Reply With Quote
 
 
 
 
Dave Peterson
Guest
Posts: n/a
 
      4th Aug 2009
It looks like:
FilesInPath = Dir(MyPath & center(i) & "*.xl*")

should be:
FilesInPath = Dir(MyPath & center(i) & "\*.xl*")
or
FilesInPath = Dir(MyPath & center(i) & "\" & "*.xl*")









Bishop wrote:
>
> I have the following code:
>
> Option Explicit
>
> Sub Consolidate()
> Dim MyPath As String
> Dim FilesInPath As String
> Dim MyFiles() As String
> Dim Fnum As Long
> Dim mybook As Workbook
> Dim CalcMode As Long
> Dim sh As Worksheet
> Dim ErrorYes As Boolean
> Dim DCLastRow As Integer 'DirectorCopy
> Dim MCLastRow As Integer 'Monthly Compiler
>
> Dim center(18) As String
> center(1) = "Bardstown"
> center(2) = "Bothell"
> center(3) = "VCollinsville"
> center(4) = "El Paso"
> center(5) = "Evansville"
> center(6) = "Greensboro"
> center(7) = "VHeathrow"
> center(8) = "Joplin"
> center(9) = "Kennesaw"
> center(10) = "Lafayette"
> center(11) = "Malvern"
> center(12) = "VManhattan"
> center(13) = "VMansfield"
> center(14) = "VOttawa"
> center(15) = "VPonco City"
> center(16) = "VReno"
> center(17) = "VSioux City"
> center(18) = "VTerra Haute"
>
> Dim FileCount As Long
> Dim ScoringAve As Double
> Dim i As Long
>
>
> 'Fill in the path\folder where the files are
> MyPath = "X:\C&A Analysts Team\PF Process\1 Tally & PF's Work in
> Progress\Centers\"
>
> For i = 1 To 18
>
> ' 'Add a slash at the end if the user forget it
> ' If Right(MyPath, 1) <> "\" Then
> ' MyPath = MyPath & "\"
> ' End If
>
> 'If there are no Excel files in the folder exit the sub
> FilesInPath = Dir(MyPath & center(i) & "*.xl*")
>
> FileInPath is showing "" all the time. Am I using Dir wrong? Why doesn't
> my path show up like I want it to? For example, if i = 2 then FilesInPath
> should look like:
>
> X:\C&A Analysts Team\PF Process\1 Tally & PF's Work in
> Progress\Centers\Bothell\*.xl*


--

Dave Peterson
 
Reply With Quote
 
Jacob Skaria
Guest
Posts: n/a
 
      4th Aug 2009
Dir(strPathandpartoffilename & "*.xl*") should retrieve the first xls file
found in the folder... Please check whether the folder is a valid folder

MyPath = "X:\C&A Analysts Team\PF Process\1 Tally & PF's Work in
Progress\Centers\"
Msgbox Dir(MyPath,vbDirectory)

(should return a dot. if the path is valid)

If this post helps click Yes
---------------
Jacob Skaria


"Bishop" wrote:

> I have the following code:
>
> Option Explicit
>
> Sub Consolidate()
> Dim MyPath As String
> Dim FilesInPath As String
> Dim MyFiles() As String
> Dim Fnum As Long
> Dim mybook As Workbook
> Dim CalcMode As Long
> Dim sh As Worksheet
> Dim ErrorYes As Boolean
> Dim DCLastRow As Integer 'DirectorCopy
> Dim MCLastRow As Integer 'Monthly Compiler
>
> Dim center(18) As String
> center(1) = "Bardstown"
> center(2) = "Bothell"
> center(3) = "VCollinsville"
> center(4) = "El Paso"
> center(5) = "Evansville"
> center(6) = "Greensboro"
> center(7) = "VHeathrow"
> center(8) = "Joplin"
> center(9) = "Kennesaw"
> center(10) = "Lafayette"
> center(11) = "Malvern"
> center(12) = "VManhattan"
> center(13) = "VMansfield"
> center(14) = "VOttawa"
> center(15) = "VPonco City"
> center(16) = "VReno"
> center(17) = "VSioux City"
> center(18) = "VTerra Haute"
>
> Dim FileCount As Long
> Dim ScoringAve As Double
> Dim i As Long
>
>
> 'Fill in the path\folder where the files are
> MyPath = "X:\C&A Analysts Team\PF Process\1 Tally & PF's Work in
> Progress\Centers\"
>
> For i = 1 To 18
>
> ' 'Add a slash at the end if the user forget it
> ' If Right(MyPath, 1) <> "\" Then
> ' MyPath = MyPath & "\"
> ' End If
>
> 'If there are no Excel files in the folder exit the sub
> FilesInPath = Dir(MyPath & center(i) & "*.xl*")
>
> FileInPath is showing "" all the time. Am I using Dir wrong? Why doesn't
> my path show up like I want it to? For example, if i = 2 then FilesInPath
> should look like:
>
> X:\C&A Analysts Team\PF Process\1 Tally & PF's Work in
> Progress\Centers\Bothell\*.xl*

 
Reply With Quote
 
Jacob Skaria
Guest
Posts: n/a
 
      4th Aug 2009
Oops...I thought center(i) is part of file name. In that case it should be

FilesInPath = Dir(MyPath & "*" & center(i) & "*.xl*")

If it is a folder name..refer Dave's post

If this post helps click Yes
---------------
Jacob Skaria


"Jacob Skaria" wrote:

> Dir(strPathandpartoffilename & "*.xl*") should retrieve the first xls file
> found in the folder... Please check whether the folder is a valid folder
>
> MyPath = "X:\C&A Analysts Team\PF Process\1 Tally & PF's Work in
> Progress\Centers\"
> Msgbox Dir(MyPath,vbDirectory)
>
> (should return a dot. if the path is valid)
>
> If this post helps click Yes
> ---------------
> Jacob Skaria
>
>
> "Bishop" wrote:
>
> > I have the following code:
> >
> > Option Explicit
> >
> > Sub Consolidate()
> > Dim MyPath As String
> > Dim FilesInPath As String
> > Dim MyFiles() As String
> > Dim Fnum As Long
> > Dim mybook As Workbook
> > Dim CalcMode As Long
> > Dim sh As Worksheet
> > Dim ErrorYes As Boolean
> > Dim DCLastRow As Integer 'DirectorCopy
> > Dim MCLastRow As Integer 'Monthly Compiler
> >
> > Dim center(18) As String
> > center(1) = "Bardstown"
> > center(2) = "Bothell"
> > center(3) = "VCollinsville"
> > center(4) = "El Paso"
> > center(5) = "Evansville"
> > center(6) = "Greensboro"
> > center(7) = "VHeathrow"
> > center(8) = "Joplin"
> > center(9) = "Kennesaw"
> > center(10) = "Lafayette"
> > center(11) = "Malvern"
> > center(12) = "VManhattan"
> > center(13) = "VMansfield"
> > center(14) = "VOttawa"
> > center(15) = "VPonco City"
> > center(16) = "VReno"
> > center(17) = "VSioux City"
> > center(18) = "VTerra Haute"
> >
> > Dim FileCount As Long
> > Dim ScoringAve As Double
> > Dim i As Long
> >
> >
> > 'Fill in the path\folder where the files are
> > MyPath = "X:\C&A Analysts Team\PF Process\1 Tally & PF's Work in
> > Progress\Centers\"
> >
> > For i = 1 To 18
> >
> > ' 'Add a slash at the end if the user forget it
> > ' If Right(MyPath, 1) <> "\" Then
> > ' MyPath = MyPath & "\"
> > ' End If
> >
> > 'If there are no Excel files in the folder exit the sub
> > FilesInPath = Dir(MyPath & center(i) & "*.xl*")
> >
> > FileInPath is showing "" all the time. Am I using Dir wrong? Why doesn't
> > my path show up like I want it to? For example, if i = 2 then FilesInPath
> > should look like:
> >
> > X:\C&A Analysts Team\PF Process\1 Tally & PF's Work in
> > Progress\Centers\Bothell\*.xl*

 
Reply With Quote
 
 
 
Reply

Thread Tools
Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are Off



Features
 

Advertising
 

Newsgroups
 


All times are GMT +1. The time now is 09:14 PM.