I need to delete some rows from a DataTable. I am not sure if the folllowing
code is supported:

void DeleteBlankRows(DataTable dt)
{
foreach(DataRow dr in dt.Rows)
{
if(AllFieldsEmpty(dr)) dr.Delete();
}
}

I am wondering if the deletion in middle of foreach will interferer with the
interal enumeration.

Hi,

"Neo The One" <(E-Mail Removed)> wrote in message
news:89F734CF-0BAC-4BF9-BD87-(E-Mail Removed)...
>I need to delete some rows from a DataTable. I am not sure if the
>folllowing
> code is supported:
>
> void DeleteBlankRows(DataTable dt)
> {
> foreach(DataRow dr in dt.Rows)
> {
> if(AllFieldsEmpty(dr)) dr.Delete();
> }
> }
>
> I am wondering if the deletion in middle of foreach will interferer with
> the
> interal enumeration.

Yes, I wouldn't recommend that approach. The thing is that added rows are
actually removed from the list when Delete is invoked on them.
Instead, do a reverse loop (int i = dt.Rows.Count-1 ... i = 0)

--
Miha Markic [MVP C#] - RightHand .NET consulting & development
www.rthand.com
Blog: http://cs.rthand.com/blogs/blog_with_righthand/
SLODUG - Slovene Developer Users Group www.codezone-si.info

Neo - as an FYI , keep in mind the distinction is w/ Remove vs. Delete.
Delete doesn't actually remove the rows from the collection ,it simply
changes their Rowstate - HOWEVER, the collection is 'modified' so it will
cause a problem.. Remove on the other hand, takes them from the collection
and as such, will also cause a problem with the foreach syntax. Now, if you
were to call .AccpetChanges in the middle of the foreach loop w/ Delete, it
will take the row out of the collection as well which will cause a problem.
I believe you can get through one pass w/ Delete, but it's definitely not
something you want to do.

So I guess that's a lot of babble I included just to confirm that it will
cause a problem ;-). Anyway, for this operation, I'd just use a for(int i)
loop.


"Neo The One" <(E-Mail Removed)> wrote in message
news:89F734CF-0BAC-4BF9-BD87-(E-Mail Removed)...
>I need to delete some rows from a DataTable. I am not sure if the
>folllowing
> code is supported:
>
> void DeleteBlankRows(DataTable dt)
> {
> foreach(DataRow dr in dt.Rows)
> {
> if(AllFieldsEmpty(dr)) dr.Delete();
> }
> }
>
> I am wondering if the deletion in middle of foreach will interferer with
> the
> interal enumeration.