PC Review


Reply
Thread Tools Rate Thread

Delete duplicates and add worksheet name

 
 
TooN
Guest
Posts: n/a
 
      16th Jul 2009
Hello Programmers..

I have a problem with some macro's i found. I have been searching for day's
now but could not find a good solution for my problem. A lot of threads are
almost good but because of my low knowledge of programming i am not able to
adjust the macro according to my needs.

First i will explain the situation:
I have a excel sheet with about 20 worksheets. There are two "intro" sheets
with all sorts of information (they called "info" and "archive") The rest of
the sheets are project related sheets. In these project related sheets are
about 20 columns and 50 rows. The data that are in these sheets are a
download from SAP.

Problem:
The download contains duplicate numbers in column J.

Solution:
I found a few macro's that are almost good:
-------------------------------------------------------------------
Sub DeleteDuplicates()

Dim X As Long
Dim lastrow As Long
Dim ws As Worksheet
For Each ws In ActiveWorkbook.Worksheets


lastrow = Range("J65536").End(xlUp).Row
For X = lastrow To 1 Step -1
If Application.WorksheetFunction.CountIf(Range("J1:J" & X),
Range("J" & X).Text) > 1 Then
Range("J" & X).EntireRow.Delete
End If

On Error Resume Next 'Will continue if an error results
ws.Range("A1") = ws.Name

'***********************
Next X
Next ws

End Sub
-------------------------------------------------------------------

The above macro will delete all the duplicates BUT it is NOT looping through
all the the worksheets in my workbook (except for the two mentioned above).

What is wrong with my macro??? I would also (if its possible) like to add
the worksheetname automaticly according to input of Cell A10

I would apreciate if someone can help me!

Thanks
 
Reply With Quote
 
 
 
 
Jacob Skaria
Guest
Posts: n/a
 
      16th Jul 2009
Try the below

Sub DeleteDuplicates()
Dim X As Long
Dim lastrow As Long
Dim ws As Worksheet
For Each ws In ActiveWorkbook.Worksheets
If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
lastrow = ws.Range("J65536").End(xlUp).Row
For X = lastrow To 1 Step -1
If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
On Error Resume Next
Next X
ws.Range("A1") = ws.Name
End If
Next ws

End Sub


If this post helps click Yes
---------------
Jacob Skaria


"TooN" wrote:

> Hello Programmers..
>
> I have a problem with some macro's i found. I have been searching for day's
> now but could not find a good solution for my problem. A lot of threads are
> almost good but because of my low knowledge of programming i am not able to
> adjust the macro according to my needs.
>
> First i will explain the situation:
> I have a excel sheet with about 20 worksheets. There are two "intro" sheets
> with all sorts of information (they called "info" and "archive") The rest of
> the sheets are project related sheets. In these project related sheets are
> about 20 columns and 50 rows. The data that are in these sheets are a
> download from SAP.
>
> Problem:
> The download contains duplicate numbers in column J.
>
> Solution:
> I found a few macro's that are almost good:
> -------------------------------------------------------------------
> Sub DeleteDuplicates()
>
> Dim X As Long
> Dim lastrow As Long
> Dim ws As Worksheet
> For Each ws In ActiveWorkbook.Worksheets
>
>
> lastrow = Range("J65536").End(xlUp).Row
> For X = lastrow To 1 Step -1
> If Application.WorksheetFunction.CountIf(Range("J1:J" & X),
> Range("J" & X).Text) > 1 Then
> Range("J" & X).EntireRow.Delete
> End If
>
> On Error Resume Next 'Will continue if an error results
> ws.Range("A1") = ws.Name
>
> '***********************
> Next X
> Next ws
>
> End Sub
> -------------------------------------------------------------------
>
> The above macro will delete all the duplicates BUT it is NOT looping through
> all the the worksheets in my workbook (except for the two mentioned above).
>
> What is wrong with my macro??? I would also (if its possible) like to add
> the worksheetname automaticly according to input of Cell A10
>
> I would apreciate if someone can help me!
>
> Thanks

 
Reply With Quote
 
TooN
Guest
Posts: n/a
 
      16th Jul 2009
Hello Jacob,

Thanks for the quick response. It works almost perfect. There is only one
thing not yet working. I saw that the sheetname is copied to cell A1. I want
to give the sheetname the same name as Cell A10 in that specific sheet. So if
cell A10 has the value "Project123" than the sheetname should have the name
"Project123"

Thanks.

"Jacob Skaria" wrote:

> Try the below
>
> Sub DeleteDuplicates()
> Dim X As Long
> Dim lastrow As Long
> Dim ws As Worksheet
> For Each ws In ActiveWorkbook.Worksheets
> If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> lastrow = ws.Range("J65536").End(xlUp).Row
> For X = lastrow To 1 Step -1
> If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
> ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
> On Error Resume Next
> Next X
> ws.Range("A1") = ws.Name
> End If
> Next ws
>
> End Sub
>
>
> If this post helps click Yes
> ---------------
> Jacob Skaria
>
>
> "TooN" wrote:
>
> > Hello Programmers..
> >
> > I have a problem with some macro's i found. I have been searching for day's
> > now but could not find a good solution for my problem. A lot of threads are
> > almost good but because of my low knowledge of programming i am not able to
> > adjust the macro according to my needs.
> >
> > First i will explain the situation:
> > I have a excel sheet with about 20 worksheets. There are two "intro" sheets
> > with all sorts of information (they called "info" and "archive") The rest of
> > the sheets are project related sheets. In these project related sheets are
> > about 20 columns and 50 rows. The data that are in these sheets are a
> > download from SAP.
> >
> > Problem:
> > The download contains duplicate numbers in column J.
> >
> > Solution:
> > I found a few macro's that are almost good:
> > -------------------------------------------------------------------
> > Sub DeleteDuplicates()
> >
> > Dim X As Long
> > Dim lastrow As Long
> > Dim ws As Worksheet
> > For Each ws In ActiveWorkbook.Worksheets
> >
> >
> > lastrow = Range("J65536").End(xlUp).Row
> > For X = lastrow To 1 Step -1
> > If Application.WorksheetFunction.CountIf(Range("J1:J" & X),
> > Range("J" & X).Text) > 1 Then
> > Range("J" & X).EntireRow.Delete
> > End If
> >
> > On Error Resume Next 'Will continue if an error results
> > ws.Range("A1") = ws.Name
> >
> > '***********************
> > Next X
> > Next ws
> >
> > End Sub
> > -------------------------------------------------------------------
> >
> > The above macro will delete all the duplicates BUT it is NOT looping through
> > all the the worksheets in my workbook (except for the two mentioned above).
> >
> > What is wrong with my macro??? I would also (if its possible) like to add
> > the worksheetname automaticly according to input of Cell A10
> >
> > I would apreciate if someone can help me!
> >
> > Thanks

 
Reply With Quote
 
Jacob Skaria
Guest
Posts: n/a
 
      16th Jul 2009
Try the below. Make sure Range("A10") of sheets are not blank or contain any
special characters like /, \ etc'

Sub DeleteDuplicates()
Dim X As Long
Dim lastrow As Long
Dim ws As Worksheet
For Each ws In ActiveWorkbook.Worksheets
If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
lastrow = ws.Range("J65536").End(xlUp).Row
For X = lastrow To 1 Step -1
If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
On Error Resume Next
Next X
ws.Range("A1") = ws.Name
ws.Name = ws.Range("A10")
End If
Next ws

End Sub

--
If this post helps click Yes
---------------
Jacob Skaria


"TooN" wrote:

> Hello Jacob,
>
> Thanks for the quick response. It works almost perfect. There is only one
> thing not yet working. I saw that the sheetname is copied to cell A1. I want
> to give the sheetname the same name as Cell A10 in that specific sheet. So if
> cell A10 has the value "Project123" than the sheetname should have the name
> "Project123"
>
> Thanks.
>
> "Jacob Skaria" wrote:
>
> > Try the below
> >
> > Sub DeleteDuplicates()
> > Dim X As Long
> > Dim lastrow As Long
> > Dim ws As Worksheet
> > For Each ws In ActiveWorkbook.Worksheets
> > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> > lastrow = ws.Range("J65536").End(xlUp).Row
> > For X = lastrow To 1 Step -1
> > If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
> > ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
> > On Error Resume Next
> > Next X
> > ws.Range("A1") = ws.Name
> > End If
> > Next ws
> >
> > End Sub
> >
> >
> > If this post helps click Yes
> > ---------------
> > Jacob Skaria
> >
> >
> > "TooN" wrote:
> >
> > > Hello Programmers..
> > >
> > > I have a problem with some macro's i found. I have been searching for day's
> > > now but could not find a good solution for my problem. A lot of threads are
> > > almost good but because of my low knowledge of programming i am not able to
> > > adjust the macro according to my needs.
> > >
> > > First i will explain the situation:
> > > I have a excel sheet with about 20 worksheets. There are two "intro" sheets
> > > with all sorts of information (they called "info" and "archive") The rest of
> > > the sheets are project related sheets. In these project related sheets are
> > > about 20 columns and 50 rows. The data that are in these sheets are a
> > > download from SAP.
> > >
> > > Problem:
> > > The download contains duplicate numbers in column J.
> > >
> > > Solution:
> > > I found a few macro's that are almost good:
> > > -------------------------------------------------------------------
> > > Sub DeleteDuplicates()
> > >
> > > Dim X As Long
> > > Dim lastrow As Long
> > > Dim ws As Worksheet
> > > For Each ws In ActiveWorkbook.Worksheets
> > >
> > >
> > > lastrow = Range("J65536").End(xlUp).Row
> > > For X = lastrow To 1 Step -1
> > > If Application.WorksheetFunction.CountIf(Range("J1:J" & X),
> > > Range("J" & X).Text) > 1 Then
> > > Range("J" & X).EntireRow.Delete
> > > End If
> > >
> > > On Error Resume Next 'Will continue if an error results
> > > ws.Range("A1") = ws.Name
> > >
> > > '***********************
> > > Next X
> > > Next ws
> > >
> > > End Sub
> > > -------------------------------------------------------------------
> > >
> > > The above macro will delete all the duplicates BUT it is NOT looping through
> > > all the the worksheets in my workbook (except for the two mentioned above).
> > >
> > > What is wrong with my macro??? I would also (if its possible) like to add
> > > the worksheetname automaticly according to input of Cell A10
> > >
> > > I would apreciate if someone can help me!
> > >
> > > Thanks

 
Reply With Quote
 
TooN
Guest
Posts: n/a
 
      16th Jul 2009
Jacob,

one small last request. Is it possible to NOT change the name of the sheets
"INFOR" and "ARCHIVE" (same that in the macro will be skipped)

Thanks in advance!

"Jacob Skaria" wrote:

> Try the below. Make sure Range("A10") of sheets are not blank or contain any
> special characters like /, \ etc'
>
> Sub DeleteDuplicates()
> Dim X As Long
> Dim lastrow As Long
> Dim ws As Worksheet
> For Each ws In ActiveWorkbook.Worksheets
> If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> lastrow = ws.Range("J65536").End(xlUp).Row
> For X = lastrow To 1 Step -1
> If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
> ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
> On Error Resume Next
> Next X
> ws.Range("A1") = ws.Name
> ws.Name = ws.Range("A10")
> End If
> Next ws
>
> End Sub
>
> --
> If this post helps click Yes
> ---------------
> Jacob Skaria
>
>
> "TooN" wrote:
>
> > Hello Jacob,
> >
> > Thanks for the quick response. It works almost perfect. There is only one
> > thing not yet working. I saw that the sheetname is copied to cell A1. I want
> > to give the sheetname the same name as Cell A10 in that specific sheet. So if
> > cell A10 has the value "Project123" than the sheetname should have the name
> > "Project123"
> >
> > Thanks.
> >
> > "Jacob Skaria" wrote:
> >
> > > Try the below
> > >
> > > Sub DeleteDuplicates()
> > > Dim X As Long
> > > Dim lastrow As Long
> > > Dim ws As Worksheet
> > > For Each ws In ActiveWorkbook.Worksheets
> > > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> > > lastrow = ws.Range("J65536").End(xlUp).Row
> > > For X = lastrow To 1 Step -1
> > > If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
> > > ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
> > > On Error Resume Next
> > > Next X
> > > ws.Range("A1") = ws.Name
> > > End If
> > > Next ws
> > >
> > > End Sub
> > >
> > >
> > > If this post helps click Yes
> > > ---------------
> > > Jacob Skaria
> > >
> > >
> > > "TooN" wrote:
> > >
> > > > Hello Programmers..
> > > >
> > > > I have a problem with some macro's i found. I have been searching for day's
> > > > now but could not find a good solution for my problem. A lot of threads are
> > > > almost good but because of my low knowledge of programming i am not able to
> > > > adjust the macro according to my needs.
> > > >
> > > > First i will explain the situation:
> > > > I have a excel sheet with about 20 worksheets. There are two "intro" sheets
> > > > with all sorts of information (they called "info" and "archive") The rest of
> > > > the sheets are project related sheets. In these project related sheets are
> > > > about 20 columns and 50 rows. The data that are in these sheets are a
> > > > download from SAP.
> > > >
> > > > Problem:
> > > > The download contains duplicate numbers in column J.
> > > >
> > > > Solution:
> > > > I found a few macro's that are almost good:
> > > > -------------------------------------------------------------------
> > > > Sub DeleteDuplicates()
> > > >
> > > > Dim X As Long
> > > > Dim lastrow As Long
> > > > Dim ws As Worksheet
> > > > For Each ws In ActiveWorkbook.Worksheets
> > > >
> > > >
> > > > lastrow = Range("J65536").End(xlUp).Row
> > > > For X = lastrow To 1 Step -1
> > > > If Application.WorksheetFunction.CountIf(Range("J1:J" & X),
> > > > Range("J" & X).Text) > 1 Then
> > > > Range("J" & X).EntireRow.Delete
> > > > End If
> > > >
> > > > On Error Resume Next 'Will continue if an error results
> > > > ws.Range("A1") = ws.Name
> > > >
> > > > '***********************
> > > > Next X
> > > > Next ws
> > > >
> > > > End Sub
> > > > -------------------------------------------------------------------
> > > >
> > > > The above macro will delete all the duplicates BUT it is NOT looping through
> > > > all the the worksheets in my workbook (except for the two mentioned above).
> > > >
> > > > What is wrong with my macro??? I would also (if its possible) like to add
> > > > the worksheetname automaticly according to input of Cell A10
> > > >
> > > > I would apreciate if someone can help me!
> > > >
> > > > Thanks

 
Reply With Quote
 
Jacob Skaria
Guest
Posts: n/a
 
      16th Jul 2009
The current macro does that..The below line exclude these two sheets from
being renamed and from being deleted...

> If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then



If this post helps click Yes
---------------
Jacob Skaria


"TooN" wrote:

> Jacob,
>
> one small last request. Is it possible to NOT change the name of the sheets
> "INFOR" and "ARCHIVE" (same that in the macro will be skipped)
>
> Thanks in advance!
>
> "Jacob Skaria" wrote:
>
> > Try the below. Make sure Range("A10") of sheets are not blank or contain any
> > special characters like /, \ etc'
> >
> > Sub DeleteDuplicates()
> > Dim X As Long
> > Dim lastrow As Long
> > Dim ws As Worksheet
> > For Each ws In ActiveWorkbook.Worksheets
> > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> > lastrow = ws.Range("J65536").End(xlUp).Row
> > For X = lastrow To 1 Step -1
> > If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
> > ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
> > On Error Resume Next
> > Next X
> > ws.Range("A1") = ws.Name
> > ws.Name = ws.Range("A10")
> > End If
> > Next ws
> >
> > End Sub
> >
> > --
> > If this post helps click Yes
> > ---------------
> > Jacob Skaria
> >
> >
> > "TooN" wrote:
> >
> > > Hello Jacob,
> > >
> > > Thanks for the quick response. It works almost perfect. There is only one
> > > thing not yet working. I saw that the sheetname is copied to cell A1. I want
> > > to give the sheetname the same name as Cell A10 in that specific sheet. So if
> > > cell A10 has the value "Project123" than the sheetname should have the name
> > > "Project123"
> > >
> > > Thanks.
> > >
> > > "Jacob Skaria" wrote:
> > >
> > > > Try the below
> > > >
> > > > Sub DeleteDuplicates()
> > > > Dim X As Long
> > > > Dim lastrow As Long
> > > > Dim ws As Worksheet
> > > > For Each ws In ActiveWorkbook.Worksheets
> > > > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> > > > lastrow = ws.Range("J65536").End(xlUp).Row
> > > > For X = lastrow To 1 Step -1
> > > > If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
> > > > ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
> > > > On Error Resume Next
> > > > Next X
> > > > ws.Range("A1") = ws.Name
> > > > End If
> > > > Next ws
> > > >
> > > > End Sub
> > > >
> > > >
> > > > If this post helps click Yes
> > > > ---------------
> > > > Jacob Skaria
> > > >
> > > >
> > > > "TooN" wrote:
> > > >
> > > > > Hello Programmers..
> > > > >
> > > > > I have a problem with some macro's i found. I have been searching for day's
> > > > > now but could not find a good solution for my problem. A lot of threads are
> > > > > almost good but because of my low knowledge of programming i am not able to
> > > > > adjust the macro according to my needs.
> > > > >
> > > > > First i will explain the situation:
> > > > > I have a excel sheet with about 20 worksheets. There are two "intro" sheets
> > > > > with all sorts of information (they called "info" and "archive") The rest of
> > > > > the sheets are project related sheets. In these project related sheets are
> > > > > about 20 columns and 50 rows. The data that are in these sheets are a
> > > > > download from SAP.
> > > > >
> > > > > Problem:
> > > > > The download contains duplicate numbers in column J.
> > > > >
> > > > > Solution:
> > > > > I found a few macro's that are almost good:
> > > > > -------------------------------------------------------------------
> > > > > Sub DeleteDuplicates()
> > > > >
> > > > > Dim X As Long
> > > > > Dim lastrow As Long
> > > > > Dim ws As Worksheet
> > > > > For Each ws In ActiveWorkbook.Worksheets
> > > > >
> > > > >
> > > > > lastrow = Range("J65536").End(xlUp).Row
> > > > > For X = lastrow To 1 Step -1
> > > > > If Application.WorksheetFunction.CountIf(Range("J1:J" & X),
> > > > > Range("J" & X).Text) > 1 Then
> > > > > Range("J" & X).EntireRow.Delete
> > > > > End If
> > > > >
> > > > > On Error Resume Next 'Will continue if an error results
> > > > > ws.Range("A1") = ws.Name
> > > > >
> > > > > '***********************
> > > > > Next X
> > > > > Next ws
> > > > >
> > > > > End Sub
> > > > > -------------------------------------------------------------------
> > > > >
> > > > > The above macro will delete all the duplicates BUT it is NOT looping through
> > > > > all the the worksheets in my workbook (except for the two mentioned above).
> > > > >
> > > > > What is wrong with my macro??? I would also (if its possible) like to add
> > > > > the worksheetname automaticly according to input of Cell A10
> > > > >
> > > > > I would apreciate if someone can help me!
> > > > >
> > > > > Thanks

 
Reply With Quote
 
TooN
Guest
Posts: n/a
 
      16th Jul 2009
Jacob,

Sorry i missed that... you are wright, but it only skippes the INFOR sheet,
the other one is still renaming. Could it be that i am doing something wrong?

"Jacob Skaria" wrote:

> The current macro does that..The below line exclude these two sheets from
> being renamed and from being deleted...
>
> > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then

>
>
> If this post helps click Yes
> ---------------
> Jacob Skaria
>
>
> "TooN" wrote:
>
> > Jacob,
> >
> > one small last request. Is it possible to NOT change the name of the sheets
> > "INFOR" and "ARCHIVE" (same that in the macro will be skipped)
> >
> > Thanks in advance!
> >
> > "Jacob Skaria" wrote:
> >
> > > Try the below. Make sure Range("A10") of sheets are not blank or contain any
> > > special characters like /, \ etc'
> > >
> > > Sub DeleteDuplicates()
> > > Dim X As Long
> > > Dim lastrow As Long
> > > Dim ws As Worksheet
> > > For Each ws In ActiveWorkbook.Worksheets
> > > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> > > lastrow = ws.Range("J65536").End(xlUp).Row
> > > For X = lastrow To 1 Step -1
> > > If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
> > > ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
> > > On Error Resume Next
> > > Next X
> > > ws.Range("A1") = ws.Name
> > > ws.Name = ws.Range("A10")
> > > End If
> > > Next ws
> > >
> > > End Sub
> > >
> > > --
> > > If this post helps click Yes
> > > ---------------
> > > Jacob Skaria
> > >
> > >
> > > "TooN" wrote:
> > >
> > > > Hello Jacob,
> > > >
> > > > Thanks for the quick response. It works almost perfect. There is only one
> > > > thing not yet working. I saw that the sheetname is copied to cell A1. I want
> > > > to give the sheetname the same name as Cell A10 in that specific sheet. So if
> > > > cell A10 has the value "Project123" than the sheetname should have the name
> > > > "Project123"
> > > >
> > > > Thanks.
> > > >
> > > > "Jacob Skaria" wrote:
> > > >
> > > > > Try the below
> > > > >
> > > > > Sub DeleteDuplicates()
> > > > > Dim X As Long
> > > > > Dim lastrow As Long
> > > > > Dim ws As Worksheet
> > > > > For Each ws In ActiveWorkbook.Worksheets
> > > > > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> > > > > lastrow = ws.Range("J65536").End(xlUp).Row
> > > > > For X = lastrow To 1 Step -1
> > > > > If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
> > > > > ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
> > > > > On Error Resume Next
> > > > > Next X
> > > > > ws.Range("A1") = ws.Name
> > > > > End If
> > > > > Next ws
> > > > >
> > > > > End Sub
> > > > >
> > > > >
> > > > > If this post helps click Yes
> > > > > ---------------
> > > > > Jacob Skaria
> > > > >
> > > > >
> > > > > "TooN" wrote:
> > > > >
> > > > > > Hello Programmers..
> > > > > >
> > > > > > I have a problem with some macro's i found. I have been searching for day's
> > > > > > now but could not find a good solution for my problem. A lot of threads are
> > > > > > almost good but because of my low knowledge of programming i am not able to
> > > > > > adjust the macro according to my needs.
> > > > > >
> > > > > > First i will explain the situation:
> > > > > > I have a excel sheet with about 20 worksheets. There are two "intro" sheets
> > > > > > with all sorts of information (they called "info" and "archive") The rest of
> > > > > > the sheets are project related sheets. In these project related sheets are
> > > > > > about 20 columns and 50 rows. The data that are in these sheets are a
> > > > > > download from SAP.
> > > > > >
> > > > > > Problem:
> > > > > > The download contains duplicate numbers in column J.
> > > > > >
> > > > > > Solution:
> > > > > > I found a few macro's that are almost good:
> > > > > > -------------------------------------------------------------------
> > > > > > Sub DeleteDuplicates()
> > > > > >
> > > > > > Dim X As Long
> > > > > > Dim lastrow As Long
> > > > > > Dim ws As Worksheet
> > > > > > For Each ws In ActiveWorkbook.Worksheets
> > > > > >
> > > > > >
> > > > > > lastrow = Range("J65536").End(xlUp).Row
> > > > > > For X = lastrow To 1 Step -1
> > > > > > If Application.WorksheetFunction.CountIf(Range("J1:J" & X),
> > > > > > Range("J" & X).Text) > 1 Then
> > > > > > Range("J" & X).EntireRow.Delete
> > > > > > End If
> > > > > >
> > > > > > On Error Resume Next 'Will continue if an error results
> > > > > > ws.Range("A1") = ws.Name
> > > > > >
> > > > > > '***********************
> > > > > > Next X
> > > > > > Next ws
> > > > > >
> > > > > > End Sub
> > > > > > -------------------------------------------------------------------
> > > > > >
> > > > > > The above macro will delete all the duplicates BUT it is NOT looping through
> > > > > > all the the worksheets in my workbook (except for the two mentioned above).
> > > > > >
> > > > > > What is wrong with my macro??? I would also (if its possible) like to add
> > > > > > the worksheetname automaticly according to input of Cell A10
> > > > > >
> > > > > > I would apreciate if someone can help me!
> > > > > >
> > > > > > Thanks

 
Reply With Quote
 
Jacob Skaria
Guest
Posts: n/a
 
      16th Jul 2009
Check whether the sheet name is exacly as mentioned or contain any
spaces...If so remove the spaces

OR

If Trim(UCase(ws.Name)) <> "INFOR" And trim(UCase(ws.Name)) <> "ARCHIVE" Then

If this post helps click Yes
---------------
Jacob Skaria


"TooN" wrote:

> Jacob,
>
> Sorry i missed that... you are wright, but it only skippes the INFOR sheet,
> the other one is still renaming. Could it be that i am doing something wrong?
>
> "Jacob Skaria" wrote:
>
> > The current macro does that..The below line exclude these two sheets from
> > being renamed and from being deleted...
> >
> > > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then

> >
> >
> > If this post helps click Yes
> > ---------------
> > Jacob Skaria
> >
> >
> > "TooN" wrote:
> >
> > > Jacob,
> > >
> > > one small last request. Is it possible to NOT change the name of the sheets
> > > "INFOR" and "ARCHIVE" (same that in the macro will be skipped)
> > >
> > > Thanks in advance!
> > >
> > > "Jacob Skaria" wrote:
> > >
> > > > Try the below. Make sure Range("A10") of sheets are not blank or contain any
> > > > special characters like /, \ etc'
> > > >
> > > > Sub DeleteDuplicates()
> > > > Dim X As Long
> > > > Dim lastrow As Long
> > > > Dim ws As Worksheet
> > > > For Each ws In ActiveWorkbook.Worksheets
> > > > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> > > > lastrow = ws.Range("J65536").End(xlUp).Row
> > > > For X = lastrow To 1 Step -1
> > > > If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
> > > > ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
> > > > On Error Resume Next
> > > > Next X
> > > > ws.Range("A1") = ws.Name
> > > > ws.Name = ws.Range("A10")
> > > > End If
> > > > Next ws
> > > >
> > > > End Sub
> > > >
> > > > --
> > > > If this post helps click Yes
> > > > ---------------
> > > > Jacob Skaria
> > > >
> > > >
> > > > "TooN" wrote:
> > > >
> > > > > Hello Jacob,
> > > > >
> > > > > Thanks for the quick response. It works almost perfect. There is only one
> > > > > thing not yet working. I saw that the sheetname is copied to cell A1. I want
> > > > > to give the sheetname the same name as Cell A10 in that specific sheet. So if
> > > > > cell A10 has the value "Project123" than the sheetname should have the name
> > > > > "Project123"
> > > > >
> > > > > Thanks.
> > > > >
> > > > > "Jacob Skaria" wrote:
> > > > >
> > > > > > Try the below
> > > > > >
> > > > > > Sub DeleteDuplicates()
> > > > > > Dim X As Long
> > > > > > Dim lastrow As Long
> > > > > > Dim ws As Worksheet
> > > > > > For Each ws In ActiveWorkbook.Worksheets
> > > > > > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> > > > > > lastrow = ws.Range("J65536").End(xlUp).Row
> > > > > > For X = lastrow To 1 Step -1
> > > > > > If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
> > > > > > ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
> > > > > > On Error Resume Next
> > > > > > Next X
> > > > > > ws.Range("A1") = ws.Name
> > > > > > End If
> > > > > > Next ws
> > > > > >
> > > > > > End Sub
> > > > > >
> > > > > >
> > > > > > If this post helps click Yes
> > > > > > ---------------
> > > > > > Jacob Skaria
> > > > > >
> > > > > >
> > > > > > "TooN" wrote:
> > > > > >
> > > > > > > Hello Programmers..
> > > > > > >
> > > > > > > I have a problem with some macro's i found. I have been searching for day's
> > > > > > > now but could not find a good solution for my problem. A lot of threads are
> > > > > > > almost good but because of my low knowledge of programming i am not able to
> > > > > > > adjust the macro according to my needs.
> > > > > > >
> > > > > > > First i will explain the situation:
> > > > > > > I have a excel sheet with about 20 worksheets. There are two "intro" sheets
> > > > > > > with all sorts of information (they called "info" and "archive") The rest of
> > > > > > > the sheets are project related sheets. In these project related sheets are
> > > > > > > about 20 columns and 50 rows. The data that are in these sheets are a
> > > > > > > download from SAP.
> > > > > > >
> > > > > > > Problem:
> > > > > > > The download contains duplicate numbers in column J.
> > > > > > >
> > > > > > > Solution:
> > > > > > > I found a few macro's that are almost good:
> > > > > > > -------------------------------------------------------------------
> > > > > > > Sub DeleteDuplicates()
> > > > > > >
> > > > > > > Dim X As Long
> > > > > > > Dim lastrow As Long
> > > > > > > Dim ws As Worksheet
> > > > > > > For Each ws In ActiveWorkbook.Worksheets
> > > > > > >
> > > > > > >
> > > > > > > lastrow = Range("J65536").End(xlUp).Row
> > > > > > > For X = lastrow To 1 Step -1
> > > > > > > If Application.WorksheetFunction.CountIf(Range("J1:J" & X),
> > > > > > > Range("J" & X).Text) > 1 Then
> > > > > > > Range("J" & X).EntireRow.Delete
> > > > > > > End If
> > > > > > >
> > > > > > > On Error Resume Next 'Will continue if an error results
> > > > > > > ws.Range("A1") = ws.Name
> > > > > > >
> > > > > > > '***********************
> > > > > > > Next X
> > > > > > > Next ws
> > > > > > >
> > > > > > > End Sub
> > > > > > > -------------------------------------------------------------------
> > > > > > >
> > > > > > > The above macro will delete all the duplicates BUT it is NOT looping through
> > > > > > > all the the worksheets in my workbook (except for the two mentioned above).
> > > > > > >
> > > > > > > What is wrong with my macro??? I would also (if its possible) like to add
> > > > > > > the worksheetname automaticly according to input of Cell A10
> > > > > > >
> > > > > > > I would apreciate if someone can help me!
> > > > > > >
> > > > > > > Thanks

 
Reply With Quote
 
TooN
Guest
Posts: n/a
 
      16th Jul 2009
Jacob.... thanks for your time. The reason it was still changing because it
is also capital sensitive so ARCHIVE works bur Archive is not working....
anyway, got it working now!

Thanks

"Jacob Skaria" wrote:

> Check whether the sheet name is exacly as mentioned or contain any
> spaces...If so remove the spaces
>
> OR
>
> If Trim(UCase(ws.Name)) <> "INFOR" And trim(UCase(ws.Name)) <> "ARCHIVE" Then
>
> If this post helps click Yes
> ---------------
> Jacob Skaria
>
>
> "TooN" wrote:
>
> > Jacob,
> >
> > Sorry i missed that... you are wright, but it only skippes the INFOR sheet,
> > the other one is still renaming. Could it be that i am doing something wrong?
> >
> > "Jacob Skaria" wrote:
> >
> > > The current macro does that..The below line exclude these two sheets from
> > > being renamed and from being deleted...
> > >
> > > > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> > >
> > >
> > > If this post helps click Yes
> > > ---------------
> > > Jacob Skaria
> > >
> > >
> > > "TooN" wrote:
> > >
> > > > Jacob,
> > > >
> > > > one small last request. Is it possible to NOT change the name of the sheets
> > > > "INFOR" and "ARCHIVE" (same that in the macro will be skipped)
> > > >
> > > > Thanks in advance!
> > > >
> > > > "Jacob Skaria" wrote:
> > > >
> > > > > Try the below. Make sure Range("A10") of sheets are not blank or contain any
> > > > > special characters like /, \ etc'
> > > > >
> > > > > Sub DeleteDuplicates()
> > > > > Dim X As Long
> > > > > Dim lastrow As Long
> > > > > Dim ws As Worksheet
> > > > > For Each ws In ActiveWorkbook.Worksheets
> > > > > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> > > > > lastrow = ws.Range("J65536").End(xlUp).Row
> > > > > For X = lastrow To 1 Step -1
> > > > > If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
> > > > > ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
> > > > > On Error Resume Next
> > > > > Next X
> > > > > ws.Range("A1") = ws.Name
> > > > > ws.Name = ws.Range("A10")
> > > > > End If
> > > > > Next ws
> > > > >
> > > > > End Sub
> > > > >
> > > > > --
> > > > > If this post helps click Yes
> > > > > ---------------
> > > > > Jacob Skaria
> > > > >
> > > > >
> > > > > "TooN" wrote:
> > > > >
> > > > > > Hello Jacob,
> > > > > >
> > > > > > Thanks for the quick response. It works almost perfect. There is only one
> > > > > > thing not yet working. I saw that the sheetname is copied to cell A1. I want
> > > > > > to give the sheetname the same name as Cell A10 in that specific sheet. So if
> > > > > > cell A10 has the value "Project123" than the sheetname should have the name
> > > > > > "Project123"
> > > > > >
> > > > > > Thanks.
> > > > > >
> > > > > > "Jacob Skaria" wrote:
> > > > > >
> > > > > > > Try the below
> > > > > > >
> > > > > > > Sub DeleteDuplicates()
> > > > > > > Dim X As Long
> > > > > > > Dim lastrow As Long
> > > > > > > Dim ws As Worksheet
> > > > > > > For Each ws In ActiveWorkbook.Worksheets
> > > > > > > If UCase(ws.Name) <> "INFOR" And UCase(ws.Name) <> "ARCHIVE" Then
> > > > > > > lastrow = ws.Range("J65536").End(xlUp).Row
> > > > > > > For X = lastrow To 1 Step -1
> > > > > > > If Application.WorksheetFunction.CountIf(ws.Range("J1:J" & X), _
> > > > > > > ws.Range("J" & X).Text) > 1 Then ws.Range("J" & X).EntireRow.Delete
> > > > > > > On Error Resume Next
> > > > > > > Next X
> > > > > > > ws.Range("A1") = ws.Name
> > > > > > > End If
> > > > > > > Next ws
> > > > > > >
> > > > > > > End Sub
> > > > > > >
> > > > > > >
> > > > > > > If this post helps click Yes
> > > > > > > ---------------
> > > > > > > Jacob Skaria
> > > > > > >
> > > > > > >
> > > > > > > "TooN" wrote:
> > > > > > >
> > > > > > > > Hello Programmers..
> > > > > > > >
> > > > > > > > I have a problem with some macro's i found. I have been searching for day's
> > > > > > > > now but could not find a good solution for my problem. A lot of threads are
> > > > > > > > almost good but because of my low knowledge of programming i am not able to
> > > > > > > > adjust the macro according to my needs.
> > > > > > > >
> > > > > > > > First i will explain the situation:
> > > > > > > > I have a excel sheet with about 20 worksheets. There are two "intro" sheets
> > > > > > > > with all sorts of information (they called "info" and "archive") The rest of
> > > > > > > > the sheets are project related sheets. In these project related sheets are
> > > > > > > > about 20 columns and 50 rows. The data that are in these sheets are a
> > > > > > > > download from SAP.
> > > > > > > >
> > > > > > > > Problem:
> > > > > > > > The download contains duplicate numbers in column J.
> > > > > > > >
> > > > > > > > Solution:
> > > > > > > > I found a few macro's that are almost good:
> > > > > > > > -------------------------------------------------------------------
> > > > > > > > Sub DeleteDuplicates()
> > > > > > > >
> > > > > > > > Dim X As Long
> > > > > > > > Dim lastrow As Long
> > > > > > > > Dim ws As Worksheet
> > > > > > > > For Each ws In ActiveWorkbook.Worksheets
> > > > > > > >
> > > > > > > >
> > > > > > > > lastrow = Range("J65536").End(xlUp).Row
> > > > > > > > For X = lastrow To 1 Step -1
> > > > > > > > If Application.WorksheetFunction.CountIf(Range("J1:J" & X),
> > > > > > > > Range("J" & X).Text) > 1 Then
> > > > > > > > Range("J" & X).EntireRow.Delete
> > > > > > > > End If
> > > > > > > >
> > > > > > > > On Error Resume Next 'Will continue if an error results
> > > > > > > > ws.Range("A1") = ws.Name
> > > > > > > >
> > > > > > > > '***********************
> > > > > > > > Next X
> > > > > > > > Next ws
> > > > > > > >
> > > > > > > > End Sub
> > > > > > > > -------------------------------------------------------------------
> > > > > > > >
> > > > > > > > The above macro will delete all the duplicates BUT it is NOT looping through
> > > > > > > > all the the worksheets in my workbook (except for the two mentioned above).
> > > > > > > >
> > > > > > > > What is wrong with my macro??? I would also (if its possible) like to add
> > > > > > > > the worksheetname automaticly according to input of Cell A10
> > > > > > > >
> > > > > > > > I would apreciate if someone can help me!
> > > > > > > >
> > > > > > > > Thanks

 
Reply With Quote
 
 
 
Reply

Thread Tools
Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
Worksheet duplicates puiuluipui Microsoft Excel Misc 9 14th May 2009 11:07 AM
Find duplicates, sum column then delete duplicates aileen Microsoft Excel Programming 3 11th Dec 2008 05:03 PM
how do i find and delete duplicates in excel worksheet? =?Utf-8?B?bXJzdGhpY2tuZXNz?= Microsoft Excel Misc 2 28th Feb 2006 08:57 PM
delete duplicates macro to color instead of delete DKY Microsoft Excel Programming 4 22nd Dec 2005 05:44 PM
Run duplicates query and delete duplicates? =?Utf-8?B?QnJvb2s=?= Microsoft Access Queries 1 5th Oct 2005 01:18 PM


Features
 

Advertising
 

Newsgroups
 


All times are GMT +1. The time now is 10:26 PM.