Let's say, I have a form class...

public class MainForm : Form {
private CustomClass cc;

public MainForm() {
DoSomething()
InitializeComponent();
}
/// Do something more
public void ShowPreference() {
PreferenceForm pf = new PreferenceForm();
pf.sometextbox.text = cc.something;
/// etc
pf.ShwoDialog();
}
}

public class PreferenceForm: Form {
/// another form
}

Basically, when the user try to close the Preference form, I want it
to be able to modify my Custom class in my main form directly.... how
could I do that?

On Thu, 10 May 2007 13:36:57 -0700, melon <(E-Mail Removed)> wrote:

> [...]
> Basically, when the user try to close the Preference form, I want it
> to be able to modify my Custom class in my main form directly.... how
> could I do that?

As long as that class is private to your MainForm class, you can't have
the PreferenceForm modify it directly.

One way is to make the class public and allow the PreferenceForm to keep a
reference to an instance of that class. The reference would be given to
the PreferenceForm by your MainForm class before showing the dialog (by
passing it in the constructor for PreferenceForm, by setting a property,
by calling a method, whatever), and then the PreferenceForm could access
it that way. A slight variation on this theme is to just make a public
interface (probably declared by the settings dialog class, but you could
put it anywhere that is accessible to both) that your private class can
expose and pass to the settings dialog.

Another way is to expose dialog input as properties in the dialog's class
and then have the client of that class use those to apply them when I use
the dialog. This requires a little more typing, but it means that the
settings dialog isn't tied to the client's class. In many cases, the
settings in the dialog are so specific to the client that having it be
aware of the client isn't really a problem, but sometimes you'll have a
dialog that is more general-purpose. Being in the habit of keeping the
two seperated means that you can always reuse the dialog when appropriate,
without having to do additional design work.

Any of these methods seem acceptable to me. Which one works best for you
depends mostly just on what seems to fit in best with the rest of your
architectural style.

Pete

"melon" <(E-Mail Removed)> wrote in message
news:(E-Mail Removed)...
> Let's say, I have a form class...
>
> public class MainForm : Form {
> private CustomClass cc;
>
> public MainForm() {
> DoSomething()
> InitializeComponent();
> }
> /// Do something more
> public void ShowPreference() {
> PreferenceForm pf = new PreferenceForm();
> pf.sometextbox.text = cc.something;
> /// etc
> pf.ShwoDialog();
> }
> }
>
> public class PreferenceForm: Form {
> /// another form
> }
>
> Basically, when the user try to close the Preference form, I want it
> to be able to modify my Custom class in my main form directly.... how
> could I do that?

Pass custom class as a parameter in your PreferenceForm constructor.

PS

On Thu, 10 May 2007 14:31:58 -0700, PS <(E-Mail Removed)> wrote:

> Pass custom class as a parameter in your PreferenceForm constructor.

It's a private class. It can't be passed to the PreferenceForm
constructor, because the PreferenceForm class doesn't have access to it.

"melon" <(E-Mail Removed)> schrieb im Newsbeitrag
news:(E-Mail Removed)...
> Let's say, I have a form class...
>
> public class MainForm : Form {
> private CustomClass cc;
>
> public MainForm() {
> DoSomething()
> InitializeComponent();
> }
> /// Do something more
> public void ShowPreference() {
> PreferenceForm pf = new PreferenceForm();
> pf.sometextbox.text = cc.something;
> /// etc
> pf.ShwoDialog();
> }
> }
>
> public class PreferenceForm: Form {
> /// another form
> }
>
> Basically, when the user try to close the Preference form, I want it
> to be able to modify my Custom class in my main form directly.... how
> could I do that?

The PreferenceForm shouldn't modify the CustomClass.
The PreferenceForm should have a property, wich after closing returns the
result. Then the MainForm can modify its components itself. So the
PreferenceForm simply fetches input from the user, and the Mainform decides
what to do with that input.

Christof

On Fri, 11 May 2007 07:22:40 -0700, Christof Nordiek <(E-Mail Removed)> wrote:

>> public class MainForm : Form {
>> private CustomClass cc;
>>
>> [...]
>>
>> Basically, when the user try to close the Preference form, I want it
>> to be able to modify my Custom class in my main form directly.... how
>> could I do that?
>
> The PreferenceForm shouldn't modify the CustomClass.

Note that this is strictly a matter of personal preference. There is no
fundamental reason you cannot implement it that way if you want (though in
this case, the access modifier for CustomClass would have to be changed to
allow it)

Pete

"Peter Duniho" <(E-Mail Removed)> wrote in message
news(E-Mail Removed)...
> On Thu, 10 May 2007 14:31:58 -0700, PS <(E-Mail Removed)> wrote:
>
>> Pass custom class as a parameter in your PreferenceForm constructor.
>
> It's a private class. It can't be passed to the PreferenceForm
> constructor, because the PreferenceForm class doesn't have access to it.

You are saying that this will not work?

public class MainForm : Form {
private CustomClass cc;

public MainForm() {
DoSomething()
InitializeComponent();
}
/// Do something more
public void ShowPreference() {
PreferenceForm pf = new PreferenceForm(cc);
pf.sometextbox.text = cc.something;
/// etc
pf.ShwoDialog();
}
}

public class PreferenceForm: Form {
/// another form

public PreferenceForm(CustomClass cc)
{
}
}

On Sat, 12 May 2007 05:46:11 -0700, PS <(E-Mail Removed)> wrote:

>> It's a private class. It can't be passed to the PreferenceForm
>> constructor, because the PreferenceForm class doesn't have access to it.
>
> You are saying that this will not work?

Yes, that's what I'm saying. You are trying to access the CustomClass
type from your PreferenceForm class, but it's private to the MainForm
class and so not visible to the PreferenceForm class.

Pete

"Peter Duniho" <(E-Mail Removed)> wrote in message
news(E-Mail Removed)...
> On Sat, 12 May 2007 05:46:11 -0700, PS <(E-Mail Removed)> wrote:
>
>>> It's a private class. It can't be passed to the PreferenceForm
>>> constructor, because the PreferenceForm class doesn't have access to it.
>>
>> You are saying that this will not work?
>
> Yes, that's what I'm saying. You are trying to access the CustomClass
> type from your PreferenceForm class, but it's private to the MainForm
> class and so not visible to the PreferenceForm class.

No it isn't. Reread the code. cc is an INSTANCE not the class definition.

PS

On Sat, 12 May 2007 11:54:46 -0700, PS <(E-Mail Removed)> wrote:

> No it isn't. Reread the code. cc is an INSTANCE not the class definition.

Ah. Okay, you're right. I misread the code. Sorry about that.