PC Review


Reply
Thread Tools Rate Thread

Copy non-contiguous cells from all workbooks in folder

 
 
dan dungan
Guest
Posts: n/a
 
      13th Nov 2007
Hi,

We're using excel 2000 on xp pro.

In a folder, we have hundreds of workbooks with data in cells A1, A3,
F9, I38, I44 on the first sheet of each workbook.

Using Ron DeBruin's sub Basic_Example_1 copies the data from the first
worksheet in each workbook, as I require, however, I don't know how
to get the data only the data from cells A1, A3, F9, I38, I44?


Thanks,

Dan Dungan


This code shown below sets the range in the the section--

With mybook.Worksheets(1)
Set sourceRange = .Range(A1, A3, F9, I38, I44)
End With
____________________________________________________

Sub Basic_Example_1()
Dim MyPath As String, FilesInPath As String
Dim MyFiles() As String
Dim SourceRcount As Long, Fnum As Long
Dim mybook As Workbook, BaseWks As Worksheet
Dim sourceRange As Range, destrange As Range
Dim rnum As Long, CalcMode As Long

'Fill in the path\folder where the files are
MyPath = "L:\My Documents\00-MASTERS"

'Add a slash at the end if the user forget it
If Right(MyPath, 1) <> "\" Then
MyPath = MyPath & "\"
End If

'If there are no Excel files in the folder exit the sub
FilesInPath = Dir(MyPath & "*.xl*")
If FilesInPath = "" Then
MsgBox "No files found"
Exit Sub
End If

'Fill the array(myFiles)with the list of Excel files in the folder
Fnum = 0
Do While FilesInPath <> ""
Fnum = Fnum + 1
ReDim Preserve MyFiles(1 To Fnum)
MyFiles(Fnum) = FilesInPath
FilesInPath = Dir()
Loop

'Change ScreenUpdating, Calculation and EnableEvents
With Application
CalcMode = .Calculation
.Calculation = xlCalculationManual
.ScreenUpdating = False
.EnableEvents = False
End With

'Add a new workbook with one sheet
Set BaseWks = Workbooks.Add(xlWBATWorksheet).Worksheets(1)
rnum = 1

'Loop through all files in the array(myFiles)
If Fnum > 0 Then
For Fnum = LBound(MyFiles) To UBound(MyFiles)
Set mybook = Nothing
On Error Resume Next
Set mybook = Workbooks.Open(MyPath & MyFiles(Fnum))
On Error GoTo 0

If Not mybook Is Nothing Then

On Error Resume Next

With mybook.Worksheets(1)
Set sourceRange = .Range(A1, A3, F9, I38, I44)
End With

If Err.Number > 0 Then
Err.Clear
Set sourceRange = Nothing
Else
'if SourceRange use all columns then skip this
file
If sourceRange.Columns.Count >=
BaseWks.Columns.Count Then
Set sourceRange = Nothing
End If
End If
On Error GoTo 0

If Not sourceRange Is Nothing Then

SourceRcount = sourceRange.Rows.Count

If rnum + SourceRcount >= BaseWks.Rows.Count Then
MsgBox "Sorry there are not enough rows in the
sheet"
BaseWks.Columns.AutoFit
mybook.Close savechanges:=False
GoTo ExitTheSub
Else

'Copy the file name in column A
With sourceRange
BaseWks.Cells(rnum, "A"). _
Resize(.Rows.Count).Value =
MyFiles(Fnum)
End With

'Set the destrange
Set destrange = BaseWks.Range("B" & rnum)

'we copy the values from the sourceRange to
the destrange
With sourceRange
Set destrange = BaseWks.Cells(rnum, "B").
_

Resize(.Rows.Count, .Columns.Count)
End With
destrange.Value = sourceRange.Value

rnum = rnum + SourceRcount
End If
End If
mybook.Close savechanges:=False
End If

Next Fnum
BaseWks.Columns.AutoFit
End If

ExitTheSub:
'Restore ScreenUpdating, Calculation and EnableEvents
With Application
.ScreenUpdating = True
.EnableEvents = True
.Calculation = CalcMode
End With
End Sub

 
Reply With Quote
 
 
 
 
Ron de Bruin
Guest
Posts: n/a
 
      13th Nov 2007
Hi Dan

For this try
http://www.rondebruin.nl/summary2.htm

--

Regards Ron de Bruin
http://www.rondebruin.nl/tips.htm


"dan dungan" <(E-Mail Removed)> wrote in message news:(E-Mail Removed)...
> Hi,
>
> We're using excel 2000 on xp pro.
>
> In a folder, we have hundreds of workbooks with data in cells A1, A3,
> F9, I38, I44 on the first sheet of each workbook.
>
> Using Ron DeBruin's sub Basic_Example_1 copies the data from the first
> worksheet in each workbook, as I require, however, I don't know how
> to get the data only the data from cells A1, A3, F9, I38, I44?
>
>
> Thanks,
>
> Dan Dungan
>
>
> This code shown below sets the range in the the section--
>
> With mybook.Worksheets(1)
> Set sourceRange = .Range(A1, A3, F9, I38, I44)
> End With
> ____________________________________________________
>
> Sub Basic_Example_1()
> Dim MyPath As String, FilesInPath As String
> Dim MyFiles() As String
> Dim SourceRcount As Long, Fnum As Long
> Dim mybook As Workbook, BaseWks As Worksheet
> Dim sourceRange As Range, destrange As Range
> Dim rnum As Long, CalcMode As Long
>
> 'Fill in the path\folder where the files are
> MyPath = "L:\My Documents\00-MASTERS"
>
> 'Add a slash at the end if the user forget it
> If Right(MyPath, 1) <> "\" Then
> MyPath = MyPath & "\"
> End If
>
> 'If there are no Excel files in the folder exit the sub
> FilesInPath = Dir(MyPath & "*.xl*")
> If FilesInPath = "" Then
> MsgBox "No files found"
> Exit Sub
> End If
>
> 'Fill the array(myFiles)with the list of Excel files in the folder
> Fnum = 0
> Do While FilesInPath <> ""
> Fnum = Fnum + 1
> ReDim Preserve MyFiles(1 To Fnum)
> MyFiles(Fnum) = FilesInPath
> FilesInPath = Dir()
> Loop
>
> 'Change ScreenUpdating, Calculation and EnableEvents
> With Application
> CalcMode = .Calculation
> .Calculation = xlCalculationManual
> .ScreenUpdating = False
> .EnableEvents = False
> End With
>
> 'Add a new workbook with one sheet
> Set BaseWks = Workbooks.Add(xlWBATWorksheet).Worksheets(1)
> rnum = 1
>
> 'Loop through all files in the array(myFiles)
> If Fnum > 0 Then
> For Fnum = LBound(MyFiles) To UBound(MyFiles)
> Set mybook = Nothing
> On Error Resume Next
> Set mybook = Workbooks.Open(MyPath & MyFiles(Fnum))
> On Error GoTo 0
>
> If Not mybook Is Nothing Then
>
> On Error Resume Next
>
> With mybook.Worksheets(1)
> Set sourceRange = .Range(A1, A3, F9, I38, I44)
> End With
>
> If Err.Number > 0 Then
> Err.Clear
> Set sourceRange = Nothing
> Else
> 'if SourceRange use all columns then skip this
> file
> If sourceRange.Columns.Count >=
> BaseWks.Columns.Count Then
> Set sourceRange = Nothing
> End If
> End If
> On Error GoTo 0
>
> If Not sourceRange Is Nothing Then
>
> SourceRcount = sourceRange.Rows.Count
>
> If rnum + SourceRcount >= BaseWks.Rows.Count Then
> MsgBox "Sorry there are not enough rows in the
> sheet"
> BaseWks.Columns.AutoFit
> mybook.Close savechanges:=False
> GoTo ExitTheSub
> Else
>
> 'Copy the file name in column A
> With sourceRange
> BaseWks.Cells(rnum, "A"). _
> Resize(.Rows.Count).Value =
> MyFiles(Fnum)
> End With
>
> 'Set the destrange
> Set destrange = BaseWks.Range("B" & rnum)
>
> 'we copy the values from the sourceRange to
> the destrange
> With sourceRange
> Set destrange = BaseWks.Cells(rnum, "B").
> _
>
> Resize(.Rows.Count, .Columns.Count)
> End With
> destrange.Value = sourceRange.Value
>
> rnum = rnum + SourceRcount
> End If
> End If
> mybook.Close savechanges:=False
> End If
>
> Next Fnum
> BaseWks.Columns.AutoFit
> End If
>
> ExitTheSub:
> 'Restore ScreenUpdating, Calculation and EnableEvents
> With Application
> .ScreenUpdating = True
> .EnableEvents = True
> .Calculation = CalcMode
> End With
> End Sub
>

 
Reply With Quote
 
dan dungan
Guest
Posts: n/a
 
      13th Nov 2007
Thanks, Ron.

That works!

It turns out that the data is not always on the first sheet. I'm
working with workbooks created by another person who is no longer
here.

It appears there may be as many a 6 sheets in a workbook. I can run
the macro and change the sheet name or can you suggest a way to
collect this regardless of how many sheets are in each workbook?

Thanks again,

Dan

> Hi Dan
>
> For this tryhttp://www.rondebruin.nl/summary2.htm
>
> --
>


 
Reply With Quote
 
Ron de Bruin
Guest
Posts: n/a
 
      13th Nov 2007
Hi Dan

I see if I have time tomorrow to make a example for you.

To be sure you want the cells from each sheet that is in each workbook
Am I correct ?

Bed time now for me

--

Regards Ron de Bruin
http://www.rondebruin.nl/tips.htm


"dan dungan" <(E-Mail Removed)> wrote in message news:(E-Mail Removed)...
> Thanks, Ron.
>
> That works!
>
> It turns out that the data is not always on the first sheet. I'm
> working with workbooks created by another person who is no longer
> here.
>
> It appears there may be as many a 6 sheets in a workbook. I can run
> the macro and change the sheet name or can you suggest a way to
> collect this regardless of how many sheets are in each workbook?
>
> Thanks again,
>
> Dan
>
>> Hi Dan
>>
>> For this tryhttp://www.rondebruin.nl/summary2.htm
>>
>> --
>>

>

 
Reply With Quote
 
dan dungan
Guest
Posts: n/a
 
      13th Nov 2007
Hi Ron,

My last reply doesn't seem to have gone through.

Thanks for your time and attention.

The procedure at http://www.rondebruin.nl/summary2.htm works.

However, the person who designed these worksheets used different
conventions over the years, and I need to look on each sheet in the
workbook. Please suggest how I might do that.

Thanks,
Dan

On Nov 13, 1:22 pm, "Ron de Bruin" <rondebr...@kabelfoon.nl> wrote:
> Hi Dan
>
> For this tryhttp://www.rondebruin.nl/summary2.htm
>


 
Reply With Quote
 
dan dungan
Guest
Posts: n/a
 
      13th Nov 2007
Hi Ron,

It would also be useful if I could capture the worksheet name for each
row.

Thanks,

Dan

On Nov 13, 2:31 pm, "Ron de Bruin" <rondebr...@kabelfoon.nl> wrote:
> Hi Dan
>
> I see if I have time tomorrow to make a example for you.
>
> To be sure you want the cells from each sheet that is in each workbook
> Am I correct ?
>
> Bed time now for me
>




 
Reply With Quote
 
Ron de Bruin
Guest
Posts: n/a
 
      14th Nov 2007
Hi Dan

Test this one for me

Sub Basic_Example_1_Test()
Dim MyPath As String, FilesInPath As String
Dim MyFiles() As String
Dim Fnum As Long
Dim mybook As Workbook, BaseWks As Worksheet
Dim sourceRange As Range, destrange As Range
Dim rnum As Long, CalcMode As Long
Dim sh As Worksheet, I As Integer, cell As Range

'Fill in the path\folder where the files are
MyPath = "L:\My Documents\00-MASTERS"

'Add a slash at the end if the user forget it
If Right(MyPath, 1) <> "\" Then
MyPath = MyPath & "\"
End If

'If there are no Excel files in the folder exit the sub
FilesInPath = Dir(MyPath & "*.xl*")
If FilesInPath = "" Then
MsgBox "No files found"
Exit Sub
End If

'Fill the array(myFiles)with the list of Excel files in the folder
Fnum = 0
Do While FilesInPath <> ""
Fnum = Fnum + 1
ReDim Preserve MyFiles(1 To Fnum)
MyFiles(Fnum) = FilesInPath
FilesInPath = Dir()
Loop

'Change ScreenUpdating, Calculation and EnableEvents
With Application
CalcMode = .Calculation
.Calculation = xlCalculationManual
.ScreenUpdating = False
.EnableEvents = False
End With

'Add a new workbook with one sheet
Set BaseWks = Workbooks.Add(xlWBATWorksheet).Worksheets(1)
rnum = 1

'Loop through all files in the array(myFiles)
If Fnum > 0 Then
For Fnum = LBound(MyFiles) To UBound(MyFiles)
Set mybook = Nothing
On Error Resume Next
Set mybook = Workbooks.Open(MyPath & MyFiles(Fnum))
On Error GoTo 0

If Not mybook Is Nothing Then

For Each sh In mybook.Worksheets

On Error Resume Next
With sh
Set sourceRange = .Range("A1,A3,F9,I38,I44")
End With

If Err.Number > 0 Then
Err.Clear
Set sourceRange = Nothing
End If
On Error GoTo 0

If Not sourceRange Is Nothing Then
I = 3
'Copy the file name in column A
BaseWks.Cells(rnum, "A").Value = MyFiles(Fnum)
BaseWks.Cells(rnum, "B").Value = sh.Name

For Each cell In sourceRange.Areas

BaseWks.Cells(rnum, I).Value = cell.Value
I = I + 1

Next cell
rnum = rnum + 1
End If
Next sh
mybook.Close savechanges:=False
End If
Next Fnum
BaseWks.Columns.AutoFit
End If

'Restore ScreenUpdating, Calculation and EnableEvents
With Application
.ScreenUpdating = True
.EnableEvents = True
.Calculation = CalcMode
End With
End Sub



--

Regards Ron de Bruin
http://www.rondebruin.nl/tips.htm


"dan dungan" <(E-Mail Removed)> wrote in message news:(E-Mail Removed)...
> Hi Ron,
>
> It would also be useful if I could capture the worksheet name for each
> row.
>
> Thanks,
>
> Dan
>
> On Nov 13, 2:31 pm, "Ron de Bruin" <rondebr...@kabelfoon.nl> wrote:
>> Hi Dan
>>
>> I see if I have time tomorrow to make a example for you.
>>
>> To be sure you want the cells from each sheet that is in each workbook
>> Am I correct ?
>>
>> Bed time now for me
>>

>
>
>

 
Reply With Quote
 
dan dungan
Guest
Posts: n/a
 
      14th Nov 2007
Wow!

I don't know what else to say, except I must study this until I
understand it.

Thank you very much, Ron!

Dan


 
Reply With Quote
 
Ron de Bruin
Guest
Posts: n/a
 
      14th Nov 2007
Hi Dan

> Thank you very much, Ron!

You are welcome

I will clean it up a bit and add it to my site when I have time

--

Regards Ron de Bruin
http://www.rondebruin.nl/tips.htm


"dan dungan" <(E-Mail Removed)> wrote in message news:(E-Mail Removed)...
> Wow!
>
> I don't know what else to say, except I must study this until I
> understand it.
>
> Thank you very much, Ron!
>
> Dan
>
>

 
Reply With Quote
 
 
 
Reply

Thread Tools
Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
Specifying Cells To Copy Across Workbooks Not Working! dim Microsoft Excel Programming 11 11th Jan 2008 12:56 AM
Copy and Paste LAST ROW of data: non-contiguous Row, contiguous Column Sam via OfficeKB.com Microsoft Excel Programming 8 5th Nov 2007 07:18 PM
Copy a range of cells to all workbooks in a folder? harteorama@googlemail.com Microsoft Excel Programming 1 12th Sep 2007 07:06 PM
How do I copy cells that link several workbooks? =?Utf-8?B?S2VsbGkgQnJvd24=?= Microsoft Excel Misc 3 25th Oct 2004 07:58 PM
Copy cells from other workbooks kronos Microsoft Excel Programming 1 22nd Apr 2004 04:57 PM


Features
 

Advertising
 

Newsgroups
 


All times are GMT +1. The time now is 11:28 AM.