PC Review


Reply
Thread Tools Rate Thread

Copy all data into one sheet and insert origin data... code amend...

 
 
harteorama@googlemail.com
Guest
Posts: n/a
 
      15th Sep 2008

Hi all,

Can anybody please help, i have some code (below) that copies all of
my data in all sheets into a master. Is there a way to put the sheet
name in Col B next to the copied data so i can see where it came from?

Many thanks in advance,

Cheers

P

Sub CopyFromWorksheets()
Dim wrk As Workbook 'Workbook object - Always good to work with
object variables
Dim sht As Worksheet 'Object for handling worksheets in loop
Dim trg As Worksheet 'Master Worksheet
Dim rng As Range 'Range object
Dim colCount As Integer 'Column count in tables in the worksheets

Set wrk = ActiveWorkbook 'Working in active workbook

For Each sht In wrk.Worksheets
If sht.Name = "Master" Then
MsgBox "There is a worksheet called as 'Master'." & vbCrLf
& _
"Please remove or rename this worksheet since 'Master'
would be" & _
"the name of the result worksheet of this process.",
vbOKOnly + vbExclamation, "Error"
Exit Sub
End If
Next sht

'We don't want screen updating
Application.ScreenUpdating = False

'Add new worksheet as the last worksheet
Set trg =
wrk.Worksheets.Add(After:=wrk.Worksheets(wrk.Worksheets.Count))
'Rename the new worksheet
trg.Name = "Master"
'Get column headers from the first worksheet
'Column count first
Set sht = wrk.Worksheets(1)
colCount = sht.Cells(1, 255).End(xlToLeft).Column
'Now retrieve headers, no copy&paste needed
With trg.Cells(1, 1).Resize(1, colCount)
.Value = sht.Cells(1, 1).Resize(1, colCount).Value
'Set font as bold
.Font.Bold = True
End With

'We can start loop
For Each sht In wrk.Worksheets
'If worksheet in loop is the last one, stop execution (it is
Master worksheet)
If sht.Index = wrk.Worksheets.Count Then
Exit For
End If
'Data range in worksheet - starts from second row as first
rows are the header rows in all worksheets
Set rng = sht.Range(sht.Cells(2, 1), sht.Cells(65536,
1).End(xlUp).Resize(, colCount))
'Put data into the Master worksheet
trg.Cells(65536, 1).End(xlUp).Offset(1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = rng.Value
Next sht
'Fit the columns in Master worksheet
trg.Columns.AutoFit

'Screen updating should be activated
Application.ScreenUpdating = True
End Sub


 
Reply With Quote
 
 
 
 
Joel
Guest
Posts: n/a
 
      15th Sep 2008
from
trg.Cells(65536, 1).End(xlUp).Offset(1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = rng.Value


to
trg.Cells(65536, 1).End(xlUp).Offset(1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = rng.Value
trg.Cells(65536, 1).End(xlUp).Offset(1,1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = sht.name


"(E-Mail Removed)" wrote:

>
> Hi all,
>
> Can anybody please help, i have some code (below) that copies all of
> my data in all sheets into a master. Is there a way to put the sheet
> name in Col B next to the copied data so i can see where it came from?
>
> Many thanks in advance,
>
> Cheers
>
> P
>
> Sub CopyFromWorksheets()
> Dim wrk As Workbook 'Workbook object - Always good to work with
> object variables
> Dim sht As Worksheet 'Object for handling worksheets in loop
> Dim trg As Worksheet 'Master Worksheet
> Dim rng As Range 'Range object
> Dim colCount As Integer 'Column count in tables in the worksheets
>
> Set wrk = ActiveWorkbook 'Working in active workbook
>
> For Each sht In wrk.Worksheets
> If sht.Name = "Master" Then
> MsgBox "There is a worksheet called as 'Master'." & vbCrLf
> & _
> "Please remove or rename this worksheet since 'Master'
> would be" & _
> "the name of the result worksheet of this process.",
> vbOKOnly + vbExclamation, "Error"
> Exit Sub
> End If
> Next sht
>
> 'We don't want screen updating
> Application.ScreenUpdating = False
>
> 'Add new worksheet as the last worksheet
> Set trg =
> wrk.Worksheets.Add(After:=wrk.Worksheets(wrk.Worksheets.Count))
> 'Rename the new worksheet
> trg.Name = "Master"
> 'Get column headers from the first worksheet
> 'Column count first
> Set sht = wrk.Worksheets(1)
> colCount = sht.Cells(1, 255).End(xlToLeft).Column
> 'Now retrieve headers, no copy&paste needed
> With trg.Cells(1, 1).Resize(1, colCount)
> .Value = sht.Cells(1, 1).Resize(1, colCount).Value
> 'Set font as bold
> .Font.Bold = True
> End With
>
> 'We can start loop
> For Each sht In wrk.Worksheets
> 'If worksheet in loop is the last one, stop execution (it is
> Master worksheet)
> If sht.Index = wrk.Worksheets.Count Then
> Exit For
> End If
> 'Data range in worksheet - starts from second row as first
> rows are the header rows in all worksheets
> Set rng = sht.Range(sht.Cells(2, 1), sht.Cells(65536,
> 1).End(xlUp).Resize(, colCount))
> 'Put data into the Master worksheet
> trg.Cells(65536, 1).End(xlUp).Offset(1).Resize(rng.Rows.Count,
> rng.Columns.Count).Value = rng.Value
> Next sht
> 'Fit the columns in Master worksheet
> trg.Columns.AutoFit
>
> 'Screen updating should be activated
> Application.ScreenUpdating = True
> End Sub
>
>
>

 
Reply With Quote
 
harteorama@googlemail.com
Guest
Posts: n/a
 
      15th Sep 2008
Hi,

Ive tried the amendments, but, it doesnt quite work - its putting the
sheet names next to the wrong entries. i.e. i have

sheet 1

Col A
ABC112
HGF321

Sheet 2

Col A
POL008
OOL001


What is actually being copied to the Master Sheet is


Col A
ABC112
HGF321
POL008 Sheet1
OOL001 Sheet1
..... Sheet2
..... Sheet2

Hope this makes sense...

cheers

P
 
Reply With Quote
 
Joel
Guest
Posts: n/a
 
      15th Sep 2008
Try reversing the two statments.

from
trg.Cells(65536, 1).End(xlUp).Offset(1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = rng.Value
trg.Cells(65536, 1).End(xlUp).Offset(1,1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = sht.name


to
trg.Cells(65536, 1).End(xlUp).Offset(1,1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = sht.name
trg.Cells(65536, 1).End(xlUp).Offset(1).Resize(rng.Rows.Count,
rng.Columns.Count).Value = rng.Value

"(E-Mail Removed)" wrote:

> Hi,
>
> Ive tried the amendments, but, it doesnt quite work - its putting the
> sheet names next to the wrong entries. i.e. i have
>
> sheet 1
>
> Col A
> ABC112
> HGF321
>
> Sheet 2
>
> Col A
> POL008
> OOL001
>
>
> What is actually being copied to the Master Sheet is
>
>
> Col A
> ABC112
> HGF321
> POL008 Sheet1
> OOL001 Sheet1
> ..... Sheet2
> ..... Sheet2
>
> Hope this makes sense...
>
> cheers
>
> P
>

 
Reply With Quote
 
 
 
Reply

Thread Tools
Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
Auto copy cell data from source sheet to another wrkbook sheet IVLUTA Microsoft Excel Programming 2 2nd Jun 2009 05:07 PM
Macro: Insert, copy and past data from sheet =?Utf-8?B?TWV0YWxkcmVhbTc=?= Microsoft Excel Misc 0 8th Nov 2006 09:31 PM
Copy data from column that begins with data to new sheet Snapdaddy Microsoft Excel Discussion 1 17th Apr 2006 12:25 AM
Data copy from a seperate sheet to data sheet ZeroXevo Microsoft Excel Programming 1 20th Jun 2005 08:14 AM
Help on writing a code to copy and amend lines Karen Brown Microsoft Excel Programming 2 5th Feb 2004 05:51 PM


Features
 

Advertising
 

Newsgroups
 


All times are GMT +1. The time now is 05:07 AM.