Many times I have a Dictionary<string, SomeType> and need to get the
list of keys out of it as a List<string>, to pass to a another method
that expects a List<string>.

I often do the following:

<BEGIN CODE>
List<string> keyNameList = new List<string>();

foreach (string keyName in this.myDictionary.Keys)
{
keyNameList.Add(keyName);
}

someObject.someMethod(keyNameList);
<END CODE>

But it seems like there should be something built-in to give me a List
of the keys.
Am I missing something, or am I doing it the best way?

Thanks
Buzz

Buzz,

You will want to do this:

// Get the list.
List<string> keyNameList = new List<string>(this.myDictionary.Keys);

That will populate the list for you with the keys in the dictionary.

If your method is not going to modify the list, then you are better off
taking a parameter of IEnumerable<string> and not List<string>. A list is
desirable when you have to make modifications to the list, but if you are
just iterating through the list, without having to make changes to the list
(but maybe to the members of the list), then IEnumerable<string> is the
better choice.

Hope this helps.


--
- Nicholas Paldino [.NET/C# MVP]
- (E-Mail Removed)

<(E-Mail Removed)> wrote in message
news:(E-Mail Removed)...
>
> Many times I have a Dictionary<string, SomeType> and need to get the
> list of keys out of it as a List<string>, to pass to a another method
> that expects a List<string>.
>
> I often do the following:
>
> <BEGIN CODE>
> List<string> keyNameList = new List<string>();
>
> foreach (string keyName in this.myDictionary.Keys)
> {
> keyNameList.Add(keyName);
> }
>
> someObject.someMethod(keyNameList);
> <END CODE>
>
> But it seems like there should be something built-in to give me a List
> of the keys.
> Am I missing something, or am I doing it the best way?
>
> Thanks
> Buzz
>

Thank you Nicholas.
Great advice. I'll be using your IEnumerable tip also.

Buzz

Nicholas Paldino [.NET/C# MVP] wrote:
> Buzz,
>
> You will want to do this:
>
> // Get the list.
> List<string> keyNameList = new List<string>(this.myDictionary.Keys);
>
> That will populate the list for you with the keys in the dictionary.
>
> If your method is not going to modify the list, then you are better off
> taking a parameter of IEnumerable<string> and not List<string>. A list is
> desirable when you have to make modifications to the list, but if you are
> just iterating through the list, without having to make changes to the list
> (but maybe to the members of the list), then IEnumerable<string> is the
> better choice.
>
> Hope this helps.
>
>
> --
> - Nicholas Paldino [.NET/C# MVP]
> - (E-Mail Removed)
>
> <(E-Mail Removed)> wrote in message
> news:(E-Mail Removed)...
> >
> > Many times I have a Dictionary<string, SomeType> and need to get the
> > list of keys out of it as a List<string>, to pass to a another method
> > that expects a List<string>.
> >
> > I often do the following:
> >
> > <BEGIN CODE>
> > List<string> keyNameList = new List<string>();
> >
> > foreach (string keyName in this.myDictionary.Keys)
> > {
> > keyNameList.Add(keyName);
> > }
> >
> > someObject.someMethod(keyNameList);
> > <END CODE>
> >
> > But it seems like there should be something built-in to give me a List
> > of the keys.
> > Am I missing something, or am I doing it the best way?
> >
> > Thanks
> > Buzz
> >

Nicholas Paldino [.NET/C# MVP] wrote:
> Buzz,
>
> You will want to do this:
>
> // Get the list.
> List<string> keyNameList = new List<string>(this.myDictionary.Keys);
>
> That will populate the list for you with the keys in the dictionary.
>
> If your method is not going to modify the list, then you are better off
> taking a parameter of IEnumerable<string> and not List<string>. A list is
> desirable when you have to make modifications to the list, but if you are
> just iterating through the list, without having to make changes to the list
> (but maybe to the members of the list), then IEnumerable<string> is the
> better choice.

If you just want an IEnumerable<K>, then Dictionary<K,V>.Keys is a
Dictionary.KeyCollection<K>, which implements IEnumerable<K> already.

static void Main(string[] args)
{

Dictionary<string, int> dict = new Dictionary<string, int>();

dict.Add("foo", 1);
dict.Add("bar", 2);
dict.Add("pop", 3);

ListStrings(dict.Keys);

Console.ReadLine();
}

static void ListStrings(IEnumerable<string> list)
{
foreach (string s in list)
{
Console.WriteLine(s);
}
}


--
Larry Lard
(E-Mail Removed)
The address is real, but unread - please reply to the group
For VB and C# questions - tell us which version

I was passing List<string> but now I've changed to IEnumerable<string>.
But now I hit a new ugliness...
I used to take that List and use the Contains method. Now with
IEnumerable I don;t have Contains. So it looks like I'll have to
foreach through... which seems kind of lame.

So it seems I DO want to pass a List<string> and just create the list
in the more elegant way that Nicholas suggsted in the first place:
> > // Get the list.
> > List<string> keyNameList = new List<string>(this.myDictionary.Keys);

Unless there is yet more that I am missing.
Buzz

Larry Lard wrote:
> Nicholas Paldino [.NET/C# MVP] wrote:
> > Buzz,
> >
> > You will want to do this:
> >
> > // Get the list.
> > List<string> keyNameList = new List<string>(this.myDictionary.Keys);
> >
> > That will populate the list for you with the keys in the dictionary.
> >
> > If your method is not going to modify the list, then you are better off
> > taking a parameter of IEnumerable<string> and not List<string>. A list is
> > desirable when you have to make modifications to the list, but if you are
> > just iterating through the list, without having to make changes to the list
> > (but maybe to the members of the list), then IEnumerable<string> is the
> > better choice.
>
> If you just want an IEnumerable<K>, then Dictionary<K,V>.Keys is a
> Dictionary.KeyCollection<K>, which implements IEnumerable<K> already.
>
> static void Main(string[] args)
> {
>
> Dictionary<string, int> dict = new Dictionary<string, int>();
>
> dict.Add("foo", 1);
> dict.Add("bar", 2);
> dict.Add("pop", 3);
>
> ListStrings(dict.Keys);
>
> Console.ReadLine();
> }
>
> static void ListStrings(IEnumerable<string> list)
> {
> foreach (string s in list)
> {
> Console.WriteLine(s);
> }
> }
>
>
> --
> Larry Lard
> (E-Mail Removed)
> The address is real, but unread - please reply to the group
> For VB and C# questions - tell us which version

If you want Contains, then ICollection<T> may be the interface you want -
which Dictionary<TKey,TValue>.KeyCollection happens to implement...

Marc

Marc Gravell wrote:
> If you want Contains, then ICollection<T> may be the interface you want -
> which Dictionary<TKey,TValue>.KeyCollection happens to implement...

And if *all* we want to do is to see whether there is an entry with a
particular TKey, we just have to use Dictionary<,>.ContainsKey!

I love System.Collections.Generic!

--
Larry Lard
(E-Mail Removed)
The address is real, but unread - please reply to the group
For VB and C# questions - tell us which version