Hello,

I have a script that works great for email addresses in a single cell. But
whenever I do a range, the recipients never get the email.

So, how do I get a range to work with this script?

Thank you

------------

Sub Mail_ActiveSheet()
'Working in 2000-2007
Dim FileExtStr As String
Dim FileFormatNum As Long
Dim Sourcewb As Workbook
Dim Destwb As Workbook
Dim TempFilePath As String
Dim TempFileName As String
Dim OutApp As Object
Dim OutMail As Object

With Application
.ScreenUpdating = False
.EnableEvents = False
End With

Set Sourcewb = ActiveWorkbook

'Copy the sheet to a new workbook
ActiveSheet.Copy
Set Destwb = ActiveWorkbook

'Determine the Excel version and file extension/format
With Destwb
If Val(Application.Version) < 12 Then
'You use Excel 2000-2003
FileExtStr = ".xls": FileFormatNum = -4143
Else
'You use Excel 2007, we exit the sub when your answer is
'NO in the security dialog that you only see when you copy
'an sheet from a xlsm file with macro's disabled.
If Sourcewb.Name = .Name Then
With Application
.ScreenUpdating = True
.EnableEvents = True
End With
MsgBox "Your answer is NO in the security dialog"
Exit Sub
Else
Select Case Sourcewb.FileFormat
Case 51: FileExtStr = ".xlsx": FileFormatNum = 51
Case 52:
If .HasVBProject Then
FileExtStr = ".xlsm": FileFormatNum = 52
Else
FileExtStr = ".xlsx": FileFormatNum = 51
End If
Case 56: FileExtStr = ".xls": FileFormatNum = 56
Case Else: FileExtStr = ".xlsb": FileFormatNum = 50
End Select
End If
End If
End With


'Save the new workbook/Mail it/Delete it
TempFilePath = Environ$("temp") & "\"
TempFileName = ThisWorkbook.Sheets("STD-LOA").Range("E7").Value & " " &
Sourcewb.Name & " " _
& Format(Now, "dd-mmm-yy h-mm-ss")

Set OutApp = CreateObject("Outlook.Application")
OutApp.Session.Logon
Set OutMail = OutApp.CreateItem(0)

With Destwb
.SaveAs TempFilePath & TempFileName & FileExtStr, _
FileFormat:=FileFormatNum
On Error Resume Next
With OutMail
.To = Sourcewb.Name & " " &
ThisWorkbook.Sheets("EmailAddresses").Range("A2").Value
.CC = ""
.BCC = ""
.Subject = Sourcewb.Name & " - " &
ThisWorkbook.Sheets("STD-LOA").Range("E7").Value & " : " & Format(Now,
"dd-mmm-yy h-mm-ss")
.Body = ThisWorkbook.Sheets("STD-LOA").Range("E30").Value
.Attachments.Add Destwb.FullName
.Send 'or use .Display
End With
On Error GoTo 0
.Close SaveChanges:=False
End With

'Delete the file you have send
Kill TempFilePath & TempFileName & FileExtStr

Set OutMail = Nothing
Set OutApp = Nothing

With Application
.ScreenUpdating = True
.EnableEvents = True
ActiveWorkbook.FollowHyperlink "("C:\test.txt")", " ", NewWindow =
True
End With
End Sub

Does this look like an email address?

Sourcewb.Name & " " &
ThisWorkbook.Sheets("EmailAddresses").Range("A2").Value

I'm thinking it probably doesn't.

Also, when I'm testing this stuff out, I use the .display option and then
close and it's in my draft documents.
--
HTH,

Barb Reinhardt



"RoadKill" wrote:

> Hello,
>
> I have a script that works great for email addresses in a single cell. But
> whenever I do a range, the recipients never get the email.
>
> So, how do I get a range to work with this script?
>
> Thank you
>
> ------------
>
> Sub Mail_ActiveSheet()
> 'Working in 2000-2007
> Dim FileExtStr As String
> Dim FileFormatNum As Long
> Dim Sourcewb As Workbook
> Dim Destwb As Workbook
> Dim TempFilePath As String
> Dim TempFileName As String
> Dim OutApp As Object
> Dim OutMail As Object
>
> With Application
> .ScreenUpdating = False
> .EnableEvents = False
> End With
>
> Set Sourcewb = ActiveWorkbook
>
> 'Copy the sheet to a new workbook
> ActiveSheet.Copy
> Set Destwb = ActiveWorkbook
>
> 'Determine the Excel version and file extension/format
> With Destwb
> If Val(Application.Version) < 12 Then
> 'You use Excel 2000-2003
> FileExtStr = ".xls": FileFormatNum = -4143
> Else
> 'You use Excel 2007, we exit the sub when your answer is
> 'NO in the security dialog that you only see when you copy
> 'an sheet from a xlsm file with macro's disabled.
> If Sourcewb.Name = .Name Then
> With Application
> .ScreenUpdating = True
> .EnableEvents = True
> End With
> MsgBox "Your answer is NO in the security dialog"
> Exit Sub
> Else
> Select Case Sourcewb.FileFormat
> Case 51: FileExtStr = ".xlsx": FileFormatNum = 51
> Case 52:
> If .HasVBProject Then
> FileExtStr = ".xlsm": FileFormatNum = 52
> Else
> FileExtStr = ".xlsx": FileFormatNum = 51
> End If
> Case 56: FileExtStr = ".xls": FileFormatNum = 56
> Case Else: FileExtStr = ".xlsb": FileFormatNum = 50
> End Select
> End If
> End If
> End With
>
>
> 'Save the new workbook/Mail it/Delete it
> TempFilePath = Environ$("temp") & "\"
> TempFileName = ThisWorkbook.Sheets("STD-LOA").Range("E7").Value & " " &
> Sourcewb.Name & " " _
> & Format(Now, "dd-mmm-yy h-mm-ss")
>
> Set OutApp = CreateObject("Outlook.Application")
> OutApp.Session.Logon
> Set OutMail = OutApp.CreateItem(0)
>
> With Destwb
> .SaveAs TempFilePath & TempFileName & FileExtStr, _
> FileFormat:=FileFormatNum
> On Error Resume Next
> With OutMail
> .To = Sourcewb.Name & " " &
> ThisWorkbook.Sheets("EmailAddresses").Range("A2").Value
> .CC = ""
> .BCC = ""
> .Subject = Sourcewb.Name & " - " &
> ThisWorkbook.Sheets("STD-LOA").Range("E7").Value & " : " & Format(Now,
> "dd-mmm-yy h-mm-ss")
> .Body = ThisWorkbook.Sheets("STD-LOA").Range("E30").Value
> .Attachments.Add Destwb.FullName
> .Send 'or use .Display
> End With
> On Error GoTo 0
> .Close SaveChanges:=False
> End With
>
> 'Delete the file you have send
> Kill TempFilePath & TempFileName & FileExtStr
>
> Set OutMail = Nothing
> Set OutApp = Nothing
>
> With Application
> .ScreenUpdating = True
> .EnableEvents = True
> ActiveWorkbook.FollowHyperlink "("C:\test.txt")", " ", NewWindow =
> True
> End With
> End Sub

Okay, I had a typo so it is actually this:
ThisWorkbook.Sheets("EmailAddresses").Range("A2").Value

When I would like it to be this:
ThisWorkbook.Sheets("EmailAddresses").Range("A2:A25").Value

However it only works when I use the former, not the latter.



"Barb Reinhardt" wrote:

> Does this look like an email address?
>
> Sourcewb.Name & " " &
> ThisWorkbook.Sheets("EmailAddresses").Range("A2").Value
>
> I'm thinking it probably doesn't.
>
> Also, when I'm testing this stuff out, I use the .display option and then
> close and it's in my draft documents.
> --
> HTH,
>
> Barb Reinhardt
>
>
>
> "RoadKill" wrote:
>
> > Hello,
> >
> > I have a script that works great for email addresses in a single cell. But
> > whenever I do a range, the recipients never get the email.
> >
> > So, how do I get a range to work with this script?
> >
> > Thank you
> >
> > ------------
> >
> > Sub Mail_ActiveSheet()
> > 'Working in 2000-2007
> > Dim FileExtStr As String
> > Dim FileFormatNum As Long
> > Dim Sourcewb As Workbook
> > Dim Destwb As Workbook
> > Dim TempFilePath As String
> > Dim TempFileName As String
> > Dim OutApp As Object
> > Dim OutMail As Object
> >
> > With Application
> > .ScreenUpdating = False
> > .EnableEvents = False
> > End With
> >
> > Set Sourcewb = ActiveWorkbook
> >
> > 'Copy the sheet to a new workbook
> > ActiveSheet.Copy
> > Set Destwb = ActiveWorkbook
> >
> > 'Determine the Excel version and file extension/format
> > With Destwb
> > If Val(Application.Version) < 12 Then
> > 'You use Excel 2000-2003
> > FileExtStr = ".xls": FileFormatNum = -4143
> > Else
> > 'You use Excel 2007, we exit the sub when your answer is
> > 'NO in the security dialog that you only see when you copy
> > 'an sheet from a xlsm file with macro's disabled.
> > If Sourcewb.Name = .Name Then
> > With Application
> > .ScreenUpdating = True
> > .EnableEvents = True
> > End With
> > MsgBox "Your answer is NO in the security dialog"
> > Exit Sub
> > Else
> > Select Case Sourcewb.FileFormat
> > Case 51: FileExtStr = ".xlsx": FileFormatNum = 51
> > Case 52:
> > If .HasVBProject Then
> > FileExtStr = ".xlsm": FileFormatNum = 52
> > Else
> > FileExtStr = ".xlsx": FileFormatNum = 51
> > End If
> > Case 56: FileExtStr = ".xls": FileFormatNum = 56
> > Case Else: FileExtStr = ".xlsb": FileFormatNum = 50
> > End Select
> > End If
> > End If
> > End With
> >
> >
> > 'Save the new workbook/Mail it/Delete it
> > TempFilePath = Environ$("temp") & "\"
> > TempFileName = ThisWorkbook.Sheets("STD-LOA").Range("E7").Value & " " &
> > Sourcewb.Name & " " _
> > & Format(Now, "dd-mmm-yy h-mm-ss")
> >
> > Set OutApp = CreateObject("Outlook.Application")
> > OutApp.Session.Logon
> > Set OutMail = OutApp.CreateItem(0)
> >
> > With Destwb
> > .SaveAs TempFilePath & TempFileName & FileExtStr, _
> > FileFormat:=FileFormatNum
> > On Error Resume Next
> > With OutMail
> > .To = Sourcewb.Name & " " &
> > ThisWorkbook.Sheets("EmailAddresses").Range("A2").Value
> > .CC = ""
> > .BCC = ""
> > .Subject = Sourcewb.Name & " - " &
> > ThisWorkbook.Sheets("STD-LOA").Range("E7").Value & " : " & Format(Now,
> > "dd-mmm-yy h-mm-ss")
> > .Body = ThisWorkbook.Sheets("STD-LOA").Range("E30").Value
> > .Attachments.Add Destwb.FullName
> > .Send 'or use .Display
> > End With
> > On Error GoTo 0
> > .Close SaveChanges:=False
> > End With
> >
> > 'Delete the file you have send
> > Kill TempFilePath & TempFileName & FileExtStr
> >
> > Set OutMail = Nothing
> > Set OutApp = Nothing
> >
> > With Application
> > .ScreenUpdating = True
> > .EnableEvents = True
> > ActiveWorkbook.FollowHyperlink "("C:\test.txt")", " ", NewWindow =
> > True
> > End With
> > End Sub

The To property of an outlook mailitem:
"Returns or sets a semicolon-delimited String list of display names for the
To recipients for the Outlook item. "
So you may have to build a string from the Range rather than expecting
Excel/Outlook to do it for you. Sort of:

Dim dList as string
for i = 2 to 25
dList = dList & <book.sheet>.Range("A" & i).value
if i < 25 then dList = dList & ";"
next i
....
.To = dList
....

--
LMH


"RoadKill" wrote:

> Okay, I had a typo so it is actually this:
> ThisWorkbook.Sheets("EmailAddresses").Range("A2").Value
>
> When I would like it to be this:
> ThisWorkbook.Sheets("EmailAddresses").Range("A2:A25").Value
>
> However it only works when I use the former, not the latter.
>
>
>
> "Barb Reinhardt" wrote:
>
> > Does this look like an email address?
> >
> > Sourcewb.Name & " " &
> > ThisWorkbook.Sheets("EmailAddresses").Range("A2").Value
> >
> > I'm thinking it probably doesn't.
> >
> > Also, when I'm testing this stuff out, I use the .display option and then
> > close and it's in my draft documents.
> > --
> > HTH,
> >
> > Barb Reinhardt
> >
> >
> >
> > "RoadKill" wrote:
> >
> > > Hello,
> > >
> > > I have a script that works great for email addresses in a single cell. But
> > > whenever I do a range, the recipients never get the email.
> > >
> > > So, how do I get a range to work with this script?
> > >
> > > Thank you
> > >
> > > ------------
> > >
> > > Sub Mail_ActiveSheet()
> > > 'Working in 2000-2007
> > > Dim FileExtStr As String
> > > Dim FileFormatNum As Long
> > > Dim Sourcewb As Workbook
> > > Dim Destwb As Workbook
> > > Dim TempFilePath As String
> > > Dim TempFileName As String
> > > Dim OutApp As Object
> > > Dim OutMail As Object
> > >
> > > With Application
> > > .ScreenUpdating = False
> > > .EnableEvents = False
> > > End With
> > >
> > > Set Sourcewb = ActiveWorkbook
> > >
> > > 'Copy the sheet to a new workbook
> > > ActiveSheet.Copy
> > > Set Destwb = ActiveWorkbook
> > >
> > > 'Determine the Excel version and file extension/format
> > > With Destwb
> > > If Val(Application.Version) < 12 Then
> > > 'You use Excel 2000-2003
> > > FileExtStr = ".xls": FileFormatNum = -4143
> > > Else
> > > 'You use Excel 2007, we exit the sub when your answer is
> > > 'NO in the security dialog that you only see when you copy
> > > 'an sheet from a xlsm file with macro's disabled.
> > > If Sourcewb.Name = .Name Then
> > > With Application
> > > .ScreenUpdating = True
> > > .EnableEvents = True
> > > End With
> > > MsgBox "Your answer is NO in the security dialog"
> > > Exit Sub
> > > Else
> > > Select Case Sourcewb.FileFormat
> > > Case 51: FileExtStr = ".xlsx": FileFormatNum = 51
> > > Case 52:
> > > If .HasVBProject Then
> > > FileExtStr = ".xlsm": FileFormatNum = 52
> > > Else
> > > FileExtStr = ".xlsx": FileFormatNum = 51
> > > End If
> > > Case 56: FileExtStr = ".xls": FileFormatNum = 56
> > > Case Else: FileExtStr = ".xlsb": FileFormatNum = 50
> > > End Select
> > > End If
> > > End If
> > > End With
> > >
> > >
> > > 'Save the new workbook/Mail it/Delete it
> > > TempFilePath = Environ$("temp") & "\"
> > > TempFileName = ThisWorkbook.Sheets("STD-LOA").Range("E7").Value & " " &
> > > Sourcewb.Name & " " _
> > > & Format(Now, "dd-mmm-yy h-mm-ss")
> > >
> > > Set OutApp = CreateObject("Outlook.Application")
> > > OutApp.Session.Logon
> > > Set OutMail = OutApp.CreateItem(0)
> > >
> > > With Destwb
> > > .SaveAs TempFilePath & TempFileName & FileExtStr, _
> > > FileFormat:=FileFormatNum
> > > On Error Resume Next
> > > With OutMail
> > > .To = Sourcewb.Name & " " &
> > > ThisWorkbook.Sheets("EmailAddresses").Range("A2").Value
> > > .CC = ""
> > > .BCC = ""
> > > .Subject = Sourcewb.Name & " - " &
> > > ThisWorkbook.Sheets("STD-LOA").Range("E7").Value & " : " & Format(Now,
> > > "dd-mmm-yy h-mm-ss")
> > > .Body = ThisWorkbook.Sheets("STD-LOA").Range("E30").Value
> > > .Attachments.Add Destwb.FullName
> > > .Send 'or use .Display
> > > End With
> > > On Error GoTo 0
> > > .Close SaveChanges:=False
> > > End With
> > >
> > > 'Delete the file you have send
> > > Kill TempFilePath & TempFileName & FileExtStr
> > >
> > > Set OutMail = Nothing
> > > Set OutApp = Nothing
> > >
> > > With Application
> > > .ScreenUpdating = True
> > > .EnableEvents = True
> > > ActiveWorkbook.FollowHyperlink "("C:\test.txt")", " ", NewWindow =
> > > True
> > > End With
> > > End Sub

Click on the Tips link on the page with this macro
http://www.rondebruin.nl/mail/tips2.htm


--

Regards Ron de Bruin
http://www.rondebruin.nl/tips.htm


"RoadKill" <(E-Mail Removed)> wrote in message news:714323A2-9CBC-45AD-8F09-(E-Mail Removed)...
> Hello,
>
> I have a script that works great for email addresses in a single cell. But
> whenever I do a range, the recipients never get the email.
>
> So, how do I get a range to work with this script?
>
> Thank you
>
> ------------
>
> Sub Mail_ActiveSheet()
> 'Working in 2000-2007
> Dim FileExtStr As String
> Dim FileFormatNum As Long
> Dim Sourcewb As Workbook
> Dim Destwb As Workbook
> Dim TempFilePath As String
> Dim TempFileName As String
> Dim OutApp As Object
> Dim OutMail As Object
>
> With Application
> .ScreenUpdating = False
> .EnableEvents = False
> End With
>
> Set Sourcewb = ActiveWorkbook
>
> 'Copy the sheet to a new workbook
> ActiveSheet.Copy
> Set Destwb = ActiveWorkbook
>
> 'Determine the Excel version and file extension/format
> With Destwb
> If Val(Application.Version) < 12 Then
> 'You use Excel 2000-2003
> FileExtStr = ".xls": FileFormatNum = -4143
> Else
> 'You use Excel 2007, we exit the sub when your answer is
> 'NO in the security dialog that you only see when you copy
> 'an sheet from a xlsm file with macro's disabled.
> If Sourcewb.Name = .Name Then
> With Application
> .ScreenUpdating = True
> .EnableEvents = True
> End With
> MsgBox "Your answer is NO in the security dialog"
> Exit Sub
> Else
> Select Case Sourcewb.FileFormat
> Case 51: FileExtStr = ".xlsx": FileFormatNum = 51
> Case 52:
> If .HasVBProject Then
> FileExtStr = ".xlsm": FileFormatNum = 52
> Else
> FileExtStr = ".xlsx": FileFormatNum = 51
> End If
> Case 56: FileExtStr = ".xls": FileFormatNum = 56
> Case Else: FileExtStr = ".xlsb": FileFormatNum = 50
> End Select
> End If
> End If
> End With
>
>
> 'Save the new workbook/Mail it/Delete it
> TempFilePath = Environ$("temp") & "\"
> TempFileName = ThisWorkbook.Sheets("STD-LOA").Range("E7").Value & " " &
> Sourcewb.Name & " " _
> & Format(Now, "dd-mmm-yy h-mm-ss")
>
> Set OutApp = CreateObject("Outlook.Application")
> OutApp.Session.Logon
> Set OutMail = OutApp.CreateItem(0)
>
> With Destwb
> .SaveAs TempFilePath & TempFileName & FileExtStr, _
> FileFormat:=FileFormatNum
> On Error Resume Next
> With OutMail
> .To = Sourcewb.Name & " " &
> ThisWorkbook.Sheets("EmailAddresses").Range("A2").Value
> .CC = ""
> .BCC = ""
> .Subject = Sourcewb.Name & " - " &
> ThisWorkbook.Sheets("STD-LOA").Range("E7").Value & " : " & Format(Now,
> "dd-mmm-yy h-mm-ss")
> .Body = ThisWorkbook.Sheets("STD-LOA").Range("E30").Value
> .Attachments.Add Destwb.FullName
> .Send 'or use .Display
> End With
> On Error GoTo 0
> .Close SaveChanges:=False
> End With
>
> 'Delete the file you have send
> Kill TempFilePath & TempFileName & FileExtStr
>
> Set OutMail = Nothing
> Set OutApp = Nothing
>
> With Application
> .ScreenUpdating = True
> .EnableEvents = True
> ActiveWorkbook.FollowHyperlink "("C:\test.txt")", " ", NewWindow =
> True
> End With
> End Sub